1639292 - browser.engagement.max_concurrent_tab_pinned_count not recording in every session

Status: RESOLVED FIXED

(Firefox :: Tabbed Browser, defect)

Description

[Su-Young Hong]

The browser.engagement.max_concurrent_tab_pinned_count telemetry measurement is only triggered when a user actively pins a tab. For all other sessions, this measurement doesn't trigger, and it's unknown how many tabs users have pinned.

Pin tab events are rare, and we want to know if a user has tabs pinned during a session, even if they didn't pin the tab in that exact session.

Need this probe to be re-implemented so it's measuring in all subsessions (independent if user pins on that session or not).

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

Bugbug thinks this bug should belong to this component, but please revert this change in case of error.

Comment 2

[Chris H-C :chutten]

ni?andreio as one of the owners of this data collection.

But while I'm here... Hm, yes. Looks like browser.engagement.restored_pinned_tabs_count solved this problem until Firefox 67. A solution could be to review and revive that probe, or to set the initial maximum for max_concurrent_tab_pinned_count at the same place restored_pinned_tabs_count was originally set.

Comment 3

[Andrei Oprea [:andreio]]

I think it would be good to do both suggestions even if the probes would send the same number most of the time.

Comment 4

[Andrei Oprea [:andreio]]

Attachment: Bug 1639292 - Update max_concurrent_tab_pinned_count probe to record restored pinned tab count

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/512fbc8f0712
Update max_concurrent_tab_pinned_count probe to record restored pinned tab count r=janerik

Comment 6

[Alexandru Michis [:malexandru]]

https://hg.mozilla.org/mozilla-central/rev/512fbc8f0712