1639415 - Clear Recent History window no longer appears in 77 beta

Status: RESOLVED FIXED

(Thunderbird :: General, defect, P1)

Description

[MarkN]

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:77.0) Gecko/20100101 Firefox/77.0

Steps to reproduce:

click on Tools > Clear Recent History or use Ctrl+Shift+Delete

Thunderbird 77.0b2 20200511021338
Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:77.0) Gecko/20100101 Thunderbird/77.0

Actual results:

no Clear All History window appears

Expected results:

window showing Clear All History should appear as it does in previous versions eg 76b3

Comment 1

[WaltS48 [:walts48]]

I can reproduce this on Ubuntu 18.04.4 LTS Linux using TB 77.0b3.

Works using 76.0b3, broken in 77.0b1.

Not sure if this is shared code with Firefox where it is activated from History > Clear Recent History and works in Fx 77.0b8.

Comment 2

[Magnus Melin [:mkmelin]]

NotSupportedError: ChromeUtils.registerWindowActor: 'Prompt' actor is already registered. ActorManagerParent.jsm:596
addActors resource://gre/modules/ActorManagerParent.jsm:596
_init resource://gre/modules/MailGlue.jsm:125
MailGlue resource://gre/modules/MailGlue.jsm:76
toSanitize chrome://messenger/content/mailCore.js:543
oncommand chrome://messenger/content/messenger.xhtml:1

Uncaught
Exception { name: "NS_ERROR_XPC_GS_RETURNED_FAILURE", message: "ServiceManager::GetService returned failure code:", result: 2153185302, filename: "chrome://messenger/content/mailCore.js", lineNumber: 543, columnNumber: 0, data: null, stack: "toSanitize@chrome://messenger/content/mailCore.js:543:6\noncommand@chrome://messenger/content/messenger.xhtml:1:1\n", location: XPCWrappedNative_NoHelper }
mailCore.js:543

Comment 3

[Magnus Melin [:mkmelin]]

Related to the prompt stuff in bug 1640549?

Comment 4

[MarkN]

Can confirm still broken in released Thunderbird 78.0b1 - 20200611220825 and issue not shown in Beta Notes - Known Issues

Comment 5

[Geoff Lankow (:darktrojan)]

Attachment: 1639415-sanitize-window-1.diff

I can't see any reason why there's an interface to open this dialog and nothing else (nsIMailGlue), so I got rid of it.

I also don't know why a new MailGlue object is created when .getService is called (this is the real problem here), but that's irrelevant after this patch.

Comment 6

[Magnus Melin [:mkmelin]]

Comment on attachment 9156617 [details] [diff] [review]
1639415-sanitize-window-1.diff

Review of attachment 9156617 [details] [diff] [review]:
-----------------------------------------------------------------

Interesting... :) Very old cruft I suppose. r=mkmelin

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/43b5533bb521
Fix "Clear Recent History" window. r=mkmelin DONTBUILD

Comment 8

[Geoff Lankow (:darktrojan)]

Comment on attachment 9156617 [details] [diff] [review]
1639415-sanitize-window-1.diff

[Approval Request Comment]
Regression caused by (bug #): unknown
User impact if declined: clear recent history dialog unusable
Testing completed (on c-c, etc.): on c-c since yesterday
Risk to taking this patch (and alternatives if risky): minor

Comment 9

[Wayne Mery (:wsmwk)]

Comment on attachment 9156617 [details] [diff] [review]
1639415-sanitize-window-1.diff

Approved for beta

Comment 10

[Geoff Lankow (:darktrojan)]

Thunderbird 78.0b2:
https://hg.mozilla.org/releases/comm-beta/rev/db11539cc578

Comment 11

[MarkN]

Can confirm FIXED in released Thunderbird 78.0b2 - 20200616103211

thank you all