Introduce telemetry for the Compatibility side panel
Categories
(DevTools :: Inspector: Compatibility, task, P2)
Tracking
(firefox78 fixed)
Tracking | Status | |
---|---|---|
firefox78 | --- | fixed |
People
(Reporter: Honza, Assigned: daisuke)
References
(Blocks 1 open bug)
Details
Attachments
(2 files)
47 bytes,
text/x-phabricator-request
|
Details | Review | |
1.87 KB,
text/plain
|
tdsmith
:
data-review+
|
Details |
This is a follow up for bug 1625132.
The Compatibility side panel usage is currently using the following telemetry:
DEVTOOLS_CUSTOM_TIME_ACTIVE_SECONDS
;
DEVTOOLS_CUSTOM_OPENED_COUNT
;
We should introduce specific telemetry for it:
DEVTOOLS_COMPATIBILITYVIEW_OPENED_COUNT
DEVTOOLS_COMPATIBILITYVIEW_TIME_ACTIVE_SECONDS
See this function:
https://searchfox.org/mozilla-central/rev/61fceb7c0729773f544a9656f474e36cd636e5ea/devtools/client/shared/telemetry.js#720-796
Honza
Reporter | ||
Comment 1•5 years ago
|
||
Martin, do you see any data for: DEVTOOLS_CUSTOM_TIME_ACTIVE_SECONDS & DEVTOOLS_CUSTOM_OPENED_COUNT ? Perhaps this could be useful until we introduce the new telemetry.
Honza
Comment 2•5 years ago
|
||
Yes, I do see data for this probe. I'll add it to the LayoutTools Dashboard
Reporter | ||
Comment 3•5 years ago
|
||
Cool
I think that we should still introduce specific probe for the Compat panel since DEVTOOLS_CUSTOM_TIME_ACTIVE_SECONDS & DEVTOOLS_CUSTOM_OPENED_COUNT are used for all custom panels (some panels could be added by extensions). It's a fallback used for all panels that don't have their own probe.
Martin, WDYT?
Honza
Comment 4•5 years ago
|
||
Yes, we definitely need to introduce a probe specific to the webcompat panel. The data I see is flawed in that there is more history than I should see, so I can't be sure what exactly collected the data.
Reporter | ||
Comment 5•5 years ago
|
||
Great, thanks Martin.
Daisuke, it would be awesome to land this yet in 78 (if possible) to start collecting the data.
(note that the 78 soft freeze is next week Thursday).
Honza
Assignee | ||
Comment 6•5 years ago
|
||
Thank you for the notice!
I will do soon.
Assignee | ||
Comment 7•5 years ago
|
||
Reporter | ||
Comment 8•5 years ago
|
||
Comment 9•5 years ago
|
||
Comment 10•5 years ago
|
||
Comment 11•5 years ago
|
||
Backed out changeset 2cb92b52fb42 (bug 1639454) for telemetry related bustages
Push with failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&fromchange=2cb92b52fb428bfadb5c8d868531bfad95db2abb&searchStr=build&tochange=4a46d2e96770571d041d4a27f93f6b8a12999134
Backout link: https://hg.mozilla.org/integration/autoland/rev/4a46d2e96770571d041d4a27f93f6b8a12999134
Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=303854287&repo=autoland&lineNumber=3280
[task 2020-05-26T23:11:02.646Z] 23:11:02 INFO - make[4]: Entering directory '/builds/worker/workspace/obj-build/toolkit/components/telemetry'
[task 2020-05-26T23:11:02.646Z] 23:11:02 INFO - toolkit/components/telemetry/TelemetryHistogramData.inc.stub
[task 2020-05-26T23:11:02.646Z] 23:11:02 INFO - /builds/worker/workspace/obj-build/_virtualenvs/init_py3/bin/python -m mozbuild.action.file_generate /builds/worker/checkouts/gecko/toolkit/components/telemetry/build_scripts/gen_histogram_data.py main TelemetryHistogramData.inc .deps/TelemetryHistogramData.inc.pp .deps/TelemetryHistogramData.inc.stub /builds/worker/checkouts/gecko/toolkit/components/telemetry/Histograms.json /builds/worker/checkouts/gecko/dom/base/UseCounters.conf /builds/worker/checkouts/gecko/dom/base/nsDeprecatedOperationList.h ../../../layout/style/ServoCSSPropList.py /builds/worker/checkouts/gecko/servo/components/style/properties/counted_unknown_properties.py /builds/worker/checkouts/gecko/dom/base/UseCountersWorker.conf
[task 2020-05-26T23:11:02.646Z] 23:11:02 INFO - Unsupported kind "count" for histogram "DEVTOOLS_COMPATIBILITYVIEW_OPENED_COUNT":
[task 2020-05-26T23:11:02.647Z] 23:11:02 INFO - New "count" histograms are not supported on Desktop, you should use scalars instead:
[task 2020-05-26T23:11:02.647Z] 23:11:02 INFO - https://firefox-source-docs.mozilla.org/toolkit/components/telemetry/telemetry/collection/scalars.html
[task 2020-05-26T23:11:02.647Z] 23:11:02 INFO - Are you trying to add a histogram on Android? Add "operating_systems": ["android"] to your histogram definition.
[task 2020-05-26T23:11:02.647Z] 23:11:02 INFO - backend.mk:12: recipe for target '.deps/TelemetryHistogramData.inc.stub' failed
[task 2020-05-26T23:11:02.647Z] 23:11:02 ERROR - make[4]: *** [.deps/TelemetryHistogramData.inc.stub] Error 1
[task 2020-05-26T23:11:02.647Z] 23:11:02 INFO - make[4]: Leaving directory '/builds/worker/workspace/obj-build/toolkit/components/telemetry'
[task 2020-05-26T23:11:02.647Z] 23:11:02 INFO - make[4]: *** Waiting for unfinished jobs....
[task 2020-05-26T23:11:02.647Z] 23:11:02 INFO - make[4]: Entering directory '/builds/worker/workspace/obj-build/dom/bindings'
[task 2020-05-26T23:11:02.648Z] 23:11:02 INFO - rm -f Node.webidl
[task 2020-05-26T23:11:02.648Z] 23:11:02 INFO - make[4]: Leaving directory '/builds/worker/workspace/obj-build/dom/bindings'
Comment 12•5 years ago
|
||
Also seeing this starting with the backed out changes:
https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=303854232&repo=autoland&lineNumber=9876
Comment 13•5 years ago
|
||
Comment 14•5 years ago
|
||
bugherder |
Assignee | ||
Updated•5 years ago
|
Description
•