1639521 - |mach artifact toolchains| HTTPError and e.message

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[Simon Fraser [:sfraser] ⌚️GMT]

Running a test on the staging taskcluster, I encountered the following error, it appears e.message isn't valid for HTTPError in https://searchfox.org/mozilla-central/source/python/mozbuild/mozbuild/artifact_commands.py#378

[task 2020-05-20T10:43:13.476Z] ++ /builds/worker/workspace/build/src/mach artifact toolchain -v --artifact-manifest /builds/worker/artifacts/toolchains.json --tooltool-manifest /builds/worker/workspace/build/src/browser/config/tooltool-manifests/win64/vs2017.manifest --cache-dir /builds/worker/tooltool-cache --retry 5
[task 2020-05-20T10:43:14.095Z]  0:00.49 materialized mozbuild.action.tooltool.FileRecord(filename='vs2017_15.8.4.zip', size=349626009, digest='ecf1e03f6f98f86775059a43f9e7dc7e326f6643d7c08962d9f614e4f5a65b1ca63fa1cfeb0f1a3c2474bf0d4318dda960b378beb2a44ecf8a91111207f4ece5', algorithm='sha512', visibility=None)
[task 2020-05-20T10:43:14.095Z]  0:00.49 loaded manifest from file '/builds/worker/workspace/build/src/browser/config/tooltool-manifests/win64/vs2017.manifest'
[task 2020-05-20T10:43:14.095Z]  0:00.49 Setting up artifact vs2017_15.8.4.zip
[task 2020-05-20T10:43:14.095Z]  0:00.49 attempt 1/6
[task 2020-05-20T10:43:14.096Z]  0:00.49 Downloading artifact to local cache: /builds/worker/tooltool-cache/ecf1e03f6f98f86775059a43f9e7dc7e326f6643d7c08962d9f614e4f5a65b1ca63fa1cfeb0f1a3c2474bf0d4318dda960b378beb2a44ecf8a91111207f4ece5
[task 2020-05-20T10:43:14.364Z]  0:00.76 Downloading... 0.0 %
[task 2020-05-20T10:43:14.365Z]  0:00.76 Downloading... 100.0 %
[task 2020-05-20T10:43:14.366Z] Error running mach:
[task 2020-05-20T10:43:14.366Z] 
[task 2020-05-20T10:43:14.366Z]     ['artifact', 'toolchain', '-v', '--artifact-manifest', '/builds/worker/artifacts/toolchains.json', '--tooltool-manifest', '/builds/worker/workspace/build/src/browser/config/tooltool-manifests/win64/vs2017.manifest', '--cache-dir', '/builds/worker/tooltool-cache', '--retry', '5']
[task 2020-05-20T10:43:14.366Z] 
[task 2020-05-20T10:43:14.366Z] The error occurred in the implementation of the invoked mach command.
[task 2020-05-20T10:43:14.366Z] 
[task 2020-05-20T10:43:14.366Z] This should never occur and is likely a bug in the implementation of that
[task 2020-05-20T10:43:14.366Z] command.
[task 2020-05-20T10:43:14.366Z] You can invoke |./mach busted| to check if this issue is already on file. If it
[task 2020-05-20T10:43:14.366Z] isn't, please use |./mach busted file| to report it. If |./mach busted| is
[task 2020-05-20T10:43:14.366Z] misbehaving, you can also inspect the dependencies of bug 1543241.
[task 2020-05-20T10:43:14.366Z] 
[task 2020-05-20T10:43:14.366Z] If filing a bug, please include the full output of mach, including this error
[task 2020-05-20T10:43:14.366Z] message.
[task 2020-05-20T10:43:14.366Z] 
[task 2020-05-20T10:43:14.366Z] The details of the failure are as follows:
[task 2020-05-20T10:43:14.366Z] 
[task 2020-05-20T10:43:14.367Z] AttributeError: 'HTTPError' object has no attribute 'message'
[task 2020-05-20T10:43:14.367Z] 
[task 2020-05-20T10:43:14.367Z]   File "/builds/worker/workspace/build/src/python/mozbuild/mozbuild/artifact_commands.py", line 378, in artifact_toolchain
[task 2020-05-20T10:43:14.367Z]     self.log(level, 'artifact', {}, str(e.message))

Comment 1

[Ricky Stewart]

Attachment: Bug 1639521 - Fix Py3 incompatibility in `mach artifact`

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0855a5f132b3
Fix Py3 incompatibility in `mach artifact` r=nalexander

Comment 3

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/0855a5f132b3