1639700 - [RNP] Ensure that the system_rng is built with Botan

Status: RESOLVED FIXED

(Thunderbird :: Security, task)

Description

[Rob Lemley [:rjl]]

Per https://github.com/randombit/botan/blob/master/doc/building.rst#minimized-builds, it's important to make sure that the system_rng module is built with Botan to make sure there's an entropy source available.

It is being built currently, but to make sure things do not break later it should be added to the modules list in botan_configure.py.

Comment 1

[Rob Lemley [:rjl]]

Attachment: Bug 1639700 - Ensure system_rng module is enabled in Botan build. r?kaie

Comment 2

[Kai Engert [:KaiE:]]

Note: All changes that are related to OpenPGP should get uplifted to Beta branch for TB 78.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/0912301df1a9
Ensure system_rng module is enabled in Botan build. r=kaie

Comment 4

[Rob Lemley [:rjl]]

Comment on attachment 9153837 [details]
Bug 1639700 - Ensure system_rng module is enabled in Botan build. r?kaie

[Approval Request Comment]
Requesting per comment 2.

Comment 5

[Wayne Mery (:wsmwk)]

Comment on attachment 9153837 [details]
Bug 1639700 - Ensure system_rng module is enabled in Botan build. r?kaie

[Triage Comment]
Approved for beta

Comment 6

[Rob Lemley [:rjl]]

Thunderbird 78.0b1:
https://hg.mozilla.org/releases/comm-beta/rev/69b88a676c8e