Closed Bug 1639866 Opened 4 years ago Closed 3 years ago

Port Bug 1437942 "Remove search engines from langpacks" to SeaMonkey

Categories

(SeaMonkey :: Build Config, enhancement)

enhancement

Tracking

(seamonkey2.53+ fixed, seamonkey2.57esr? affected)

RESOLVED FIXED
seamonkey 2.85
Tracking Status
seamonkey2.53 + fixed
seamonkey2.57esr ? affected

People

(Reporter: frg, Assigned: frg)

References

(Blocks 1 open bug)

Details

(Whiteboard: SM2.53.8)

Attachments

(2 files, 2 obsolete files)

In bug 1300198 we centralized the search engines. For a successfull l10n build we need to port Bug 1437942 too.

Attached patch WIP-1639866-searchmove-cc.patch (obsolete) — Splinter Review

wip patch. Packaging part is complete but needs some logic changes too. Not taking bug yet. Free for grabs if someone wants to do the remaining parts.

Attached patch WIP-1639866-searchmove-cc.patch (obsolete) — Splinter Review

unbitrot patch.

Attachment #9150750 - Attachment is obsolete: true

Part 1 packaging updates.

Assignee: nobody → frgrahl
Attachment #9151614 - Attachment is obsolete: true
Attachment #9161399 - Flags: review?(iann_bugzilla)
Keywords: leave-open
Comment on attachment 9161399 [details] [diff] [review]
1639866-1-searchmove-cc.patch
checked in [comment 5]
Target SeaMonkey 2.77

Seems like a good starting point, it will be interesting when we try to backport r=me
Attachment #9161399 - Flags: review?(iann_bugzilla) → review+
Pushed by frgrahl@gmx.net:
https://hg.mozilla.org/comm-central/rev/52cfcb2c361f
Part 1: Port Bug 1437942 "Remove search engines from langpacks" to SeaMonkey. r=IanN
Attachment #9161399 - Attachment description: 1639866-1-searchmove-cc.patch → 1639866-1-searchmove-cc.patch checked in [comment 5] Target SeaMonkey 2.77

Comment on attachment 9161399 [details] [diff] [review]
1639866-1-searchmove-cc.patch
checked in [comment 5]
Target SeaMonkey 2.77

a+ for 2.57

Attachment #9161399 - Flags: approval-comm-release+

Part 2: make it actually work.
Patch from Bill r/a+ from me.

Tested with 2.57a1

Attachment #9209250 - Flags: review+
Attachment #9209250 - Flags: approval-comm-esr60+
Attachment #9161399 - Flags: approval-comm-release+ → approval-comm-esr60+

Pushed by frgrahl@gmx.net:
https://hg.mozilla.org/comm-central/rev/d6914a41697b
Part 2: Observe search service initialization after bug 1437942. r=frg

Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → seamonkey 2.85
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: