Closed Bug 1636756 Opened 5 months ago Closed 4 months ago

Created more localised versions of DuckDuckGo searchplugin

Categories

(SeaMonkey :: Search, enhancement)

enhancement

Tracking

(seamonkey2.53+ fixed, seamonkey2.57esr? affected)

RESOLVED FIXED
seamonkey 2.75
Tracking Status
seamonkey2.53 + fixed
seamonkey2.57esr ? affected

People

(Reporter: iann_bugzilla, Assigned: iann_bugzilla)

References

(Blocks 1 open bug)

Details

(Whiteboard: SM2.53.3)

Attachments

(1 file, 2 obsolete files)

Where the region parameter exists we should add it to the DuckDuckGo searchplugin. Locales with existing localised versions of the plugin already had it or did it over in Bug 1104922 but those relying on the default version could not have it, so let's change that.

Attached patch Create more searchplugins (obsolete) — Splinter Review

At the moment I have left the descriptions for the new searchplugins as:
"DuckDuckGo provides a privacy-aware search engine for the web"

I have asked DDG if they already have localised versions of the description for our locales, but I know the existing localised versions have either the above or, translated back into English, things like:
"DuckDuckGo offers web search with respect to your privacy", "Search through DuckDuckGo" and "DuckDuckGo search engine"

Maybe should somehow expose these as strings in a dtd/properties file, but that is outside the scope of this bug.

Attachment #9147094 - Flags: feedback?(rpmdisguise-nave)
Attachment #9147094 - Flags: feedback?(frgrahl)
Comment on attachment 9147094 [details] [diff] [review]
Create more searchplugins

Is there a reason for which some locales have their searchplugin XML file named with the region code in upper case (like NO) whereas most others have it in lower case (like fr, es or it)? Also, please note that, for Spanish vs. Spain, there are several countries using the language and several languaes spoken in the same country (ca for Catalan, eu for euskera and gl for Galician), so it may worth consider using the full locale-region code.

(In reply to RickieES aka Ricardo Palomares from comment #2)

Comment on attachment 9147094 [details] [diff] [review]
Create more searchplugins

Is there a reason for which some locales have their searchplugin XML file
named with the region code in upper case (like NO) whereas most others have
it in lower case (like fr, es or it)? Also, please note that, for Spanish
vs. Spain, there are several countries using the language and several
languaes spoken in the same country (ca for Catalan, eu for euskera and gl
for Galician), so it may worth consider using the full locale-region code.

I was trying to follow the existing name conventions for each locale, but may have failed in some places. DDG do have a region list in https://duckduckgo.com/params so happy to rework the patch to be in the lang-REGION format.
Is it work doing it where it makes sense for other search engine names? (In a different bug)

Flags: needinfo?(rpmdisguise-nave)

Updated naming to include both language and region/country, which makes sense for DuckDuckGo as you can specify both in the parameters that you pass to the search engine.

Attachment #9147094 - Attachment is obsolete: true
Attachment #9147094 - Flags: feedback?(rpmdisguise-nave)
Attachment #9147094 - Flags: feedback?(frgrahl)
Attachment #9149213 - Flags: feedback?(rpmdisguise-nave)
Attachment #9149213 - Flags: feedback?(frgrahl)
Comment on attachment 9149213 [details] [diff] [review]
Create more DDG searchplugins v1.1

LGTM, everything matches (the suffixes in the JSON with the searchplugin XML filenames, and the kl params in each searchplugin with the param list in DDG webpage you linked. Great, thank you very much!
Flags: needinfo?(rpmdisguise-nave)
Attachment #9149213 - Flags: feedback?(rpmdisguise-nave) → feedback+

Unbitrotted version

Attachment #9149213 - Attachment is obsolete: true
Attachment #9149213 - Flags: feedback?(frgrahl)
Attachment #9150614 - Flags: review?(frgrahl)
Attachment #9150614 - Flags: feedback+
Attachment #9150614 - Flags: approval-comm-release?
Attachment #9150614 - Flags: approval-comm-esr60?
Blocks: 1639866
Comment on attachment 9150614 [details] [diff] [review]
Create more DDG searchplugins v1.2

lgtm

Based on current faulty defaults we thought about   switching  "sv-SE" to ddg as default. Can go into a follow-up if still desired.
Attachment #9150614 - Flags: review?(frgrahl)
Attachment #9150614 - Flags: review+
Attachment #9150614 - Flags: approval-comm-release?
Attachment #9150614 - Flags: approval-comm-release+
Attachment #9150614 - Flags: approval-comm-esr60?
Attachment #9150614 - Flags: approval-comm-esr60+
Comment on attachment 9150614 [details] [diff] [review]
Create more DDG searchplugins v1.2

Stefan, defaults for sv-SE in the l10n repos seem to be broken for some time now because of a faulty lowercase google and DDG is selected as default. The current patches for 2.53.3 fixes this but do you think we should switch it officially to DGG instead of google? Can still be set by the user.
Attachment #9150614 - Flags: feedback?(stefanh)

Sending the question to Peter (sv-SE localizer).

Flags: needinfo?(peter)

(I don't mind switching)

Pushed by frgrahl@gmx.net:
https://hg.mozilla.org/comm-central/rev/8502d904e273
Created more localised versions of DuckDuckGo searchplugin. f=rpm r=frg

Status: ASSIGNED → RESOLVED
Closed: 4 months ago
Resolution: --- → FIXED

I don't mind switching, and are happy that someone has found why the current searchplugin does not work.

Flags: needinfo?(peter)
Attachment #9150614 - Flags: feedback?(stefanh)

Thanks Peter. IanN will do a followup bug.

Target Milestone: --- → seamonkey 2.75
Blocks: 1642245
Whiteboard: SM2.53.3
You need to log in before you can comment on or make changes to this bug.