1639997 - Update pre-existing WebRTC browser mochitests for the new global indicator and notification silencing

Status: RESOLVED FIXED

(Firefox :: Site Permissions, task)

Description

[Mike Conley (:mconley) (:⚙️)]

There's no guarantee that the new global shared indicator, notification silencing and tab switch warning will ship in 78, so we'll want to test with those things both off and on.

Comment 1

[Mike Conley (:mconley) (:⚙️)]

Attachment: Bug 1639997 - Use more appropriate window features for new WebRTC global indicator. r?pbz!

These features allow the indicator to not pull focus from the originating window, which
is important to maintain user task continuity, especially for screenreader users.

Comment 2

[Mike Conley (:mconley) (:⚙️)]

Attachment: Bug 1639997 - Have webrtcUI handle the case where the selectedTab is set to null. r?pbz!

It's possible for gBrowser.selectedTab to be set to null. This should be a no-op, but this
part of webrtcUI that tabbrowser calls doesn't handle the case, and causes an exception to
be thrown. This patch allows the no-op case to occur properly.

Depends on D76735

Comment 3

[Mike Conley (:mconley) (:⚙️)]

Attachment: Bug 1639997 - Split out WebRTC browser mochitests into a variation that runs with the legacy behaviour. r?pbz!

Depends on D76736

Comment 4

[Mike Conley (:mconley) (:⚙️)]

Attachment: Bug 1639997 - Update WebRTC browser mochitests to test both old and new global indicators. r?pbz!

Depends on D76737

Comment 5

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/integration/autoland/rev/1db8092803559ab0a64b532c350386e5d9bee805
https://hg.mozilla.org/integration/autoland/rev/a5fd10b6336ed07840c886b7e03829770a3482a4
https://hg.mozilla.org/integration/autoland/rev/1735b739f2f5c592e17f43b3ca287b062017075f
https://hg.mozilla.org/integration/autoland/rev/f4e08664070b8bc5f78fef734b8b064dcd53eb86
https://hg.mozilla.org/mozilla-central/rev/1db809280355
https://hg.mozilla.org/mozilla-central/rev/a5fd10b6336e
https://hg.mozilla.org/mozilla-central/rev/1735b739f2f5
https://hg.mozilla.org/mozilla-central/rev/f4e08664070b