1640070 - Shippable builds running on every push

Status: RESOLVED FIXED

(Thunderbird :: Build Config, defect)

Description

[Geoff Lankow (:darktrojan)]

Shippable builds have started running when they should not be running.

Comment 1

[Rob Lemley [:rjl]]

RFC: I would like to let these run.

AIUI, the reason for not wanting shippable builds by default was to minimize our use of Taskcluster build resources. This is certainly an admirable goal.
However, it's a maintenance burden as we deviate from what Firefox does here. The less of that sort of thing we do the better.

If we keep the shippable builds enabled, I can set "include_push_tasks" to true in our .cron.yml file for the Nightly builds. With that set, when the cron job, it will just "promote" the last push. This is something that :mkmelin has verbally asked for in recent months.

There may be other issues that come up due to the desire to not run a build for suite-only pushes. Personally, I feel that's another maintenance burden we can do without.

NI? Callek to confirm my understanding of what "include_push_tasks" will accomplish.

Comment 2

[Justin Wood (:Callek)]

Yes, that is what include_push_tasks should do, I haven't vetted the code to assure that it would work on comm correctly.

Comment 3

[Rob Lemley [:rjl]]

Attachment: Bug 1640070 - Use existing build for Thunderbird Dailies. r=justdave

As shippable builds are running on every push, this will reuse those builds
for the Dailies rather than rebuilding.

Comment 4

[Rob Lemley [:rjl]]

I took a look at the code in question and nothing stood out as being a problem.
I ran "mach taskgraph decision" locally with the --include-push-tasks parameter included and a TASK_ID set. The generated parameters.yml file did not include the build tasks though, so it looks like something is not quite right.

Comment 5

[Magnus Melin [:mkmelin]]

So that means if we push something at 13:00 and nothing changed since 14:00 (when dailies start), it wouldn't re-do them at 14?

Comment 6

[Rob Lemley [:rjl]]

Yes, that's what include_push_tasks is supposed to do anyway. I'd like to be able to try it out without breaking anything though.

Comment 7

[Rob Lemley [:rjl]]

(In reply to Rob Lemley [:rjl] from comment #4)

I took a look at the code in question and nothing stood out as being a problem.
I ran "mach taskgraph decision" locally with the --include-push-tasks parameter included and a TASK_ID set. The generated parameters.yml file did not include the build tasks though, so it looks like something is not quite right.

I figured this out... PEBKAC. If the original push to comm-central was a DONTBUILD push, obviously there are no build tasks to reuse, and that was my issue before. So let's get this thing landed and done.

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/ea8e92388dfe
Use existing build for Thunderbird Dailies. r=justdave

Comment 9

[Magnus Melin [:mkmelin]]

So what will the daily be if I land something that didn't have time to finish building before it's time for daily? Will it wait for the current push to finish and use that?

Comment 10

[Rob Lemley [:rjl]]

(In reply to Magnus Melin [:mkmelin] from comment #9)

So what will the daily be if I land something that didn't have time to finish building before it's time for daily? Will it wait for the current push to finish and use that?

It's going to look at the most recent Decision task and use that task graph as a basis. Whatever is in the label-to-taskid.json artifact will get reused, anything that's not is built. So the answer is, if builds are still going they will finish and then finish up the rest of the Nightly tasks from those.