Closed
Bug 1640191
Opened 5 years ago
Closed 5 years ago
Simplify SysColorChanged notifications.
Categories
(Core :: Widget: Win32, defect, P3)
Core
Widget: Win32
Tracking
()
RESOLVED
FIXED
mozilla79
| Tracking | Status | |
|---|---|---|
| firefox79 | --- | fixed |
People
(Reporter: emilio, Assigned: emilio)
References
Details
Attachments
(1 file)
No description provided.
|
Assignee | |
Comment 1•5 years ago
|
||
The current notification enumerates all windows and calls
SysColorChanged on them.
The current implementation of SysColorChanged is not quite sound, as it
really needs most if not all of what ThemeChanged does: SVGs can use
system colors, so we need to also invalidate the image cache for
example.
It's also not clear it deals correctly with propagating system color
changes to other documents.
In some cases we were even firing both theme changes and system color
changes at the same time. Unify this code paths.
|
||
Comment 2•5 years ago
|
||
The severity field is not set for this bug.
:jimm, could you have a look please?
For more information, please visit auto_nag documentation.
Flags: needinfo?(jmathies)
Pushed by ealvarez@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/c6eda603486d
Simplify system colors change notification. r=jmathies
|
||
Comment 4•5 years ago
|
||
| bugherder | ||
Status: NEW → RESOLVED
Closed: 5 years ago
status-firefox79:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla79
|
||
Updated•5 years ago
|
Severity: -- → S4
Flags: needinfo?(jmathies)
Priority: -- → P3
You need to log in
before you can comment on or make changes to this bug.
Description
•