1156934 - Be more efficient with how we update the LookAndFeel int cache in the content process

Status: RESOLVED FIXED

(Core :: Widget, defect, P3)

Description

[Mike Conley (:mconley) (:⚙️)]

Bug 1096093 adds a mechanism for transferring a cache of LookAndFeel values from the parent process to content processes. This cache is updated when the parent notices that the system theme has changed.

It's updated once per PresContext, via the ThemeChanged IPDL message over PBrowser.

We should really only need to do this once per content process.

Comment 1

[Randell Jesup [:jesup] (needinfo me)]

Actually hurts E10S more than fission (as there are less content processes than tabs (typically) in e10s)

Comment 2

[Randell Jesup [:jesup] (needinfo me)]

Emilio suggested notifying all content processes of the change (probably using ContentParent::GetAll()), then notifying all prescontexts within the process from there.

Comment 3

[Chris Peterson [:cpeterson]]

Jim thinks this will get fixed by LookAndFeel remoting for win32k lockdown. He'll ask gcp.

Tracking for Fission M7 Beta

Comment 4

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1156934 - Notify all content processes when LookAndFeel changes. r=jesup

This should fix the issue for preallocated processes that still don't
host any document, and also send a few less IPC messages.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/360c1a12d594
Notify all content processes when LookAndFeel changes. r=jesup

Comment 6

[Cristian Brindusan [:cbrindusan]]

https://hg.mozilla.org/mozilla-central/rev/360c1a12d594