1640206 - [UX] The Global Sharing Indicator button don't have a button press feedback

Status: NEW

(Firefox :: Site Permissions, enhancement, P3)

Description

[Daniel Bodea [:danibodea]]

Note

• The Global Sharing Indicator buttons have a hover state, but they don't have a button press state/feedback. Shouldn't it?

Affected versions

• Beta v77.0b7
• Nightly v78.0a1

Affected platforms

• Windows 10
• Windows 7
• probably also relevant to Linux/MacOS

Steps to reproduce

1. Engage in a video call.
2. Allow microphone/camera permission.
3. Notice that the Overlay is already displayed).
4. Start screen-sharing.
5. Notice the "Stop Sharing" button and relevant icon+message are added to the Overlay.
6. Hover over the buttons.
7. Notice that the buttons have a hover state.
8. Click any of them.

Expected result

• A button press feedback is expected.

Actual result

• A button press feedback is not observed.

Regression range

• Feature implementation enhancement.

Comment 1

[Mike Conley (:mconley) (:⚙️)]

Hey aaron, what should the active colour be here? Anything?

Comment 2

[Mike Conley (:mconley) (:⚙️)]

Bug 1643503 adds active colours for the minimize button and the mic/camera control buttons.

It doesn't, however, add an active colour for the Stop Sharing button. Hey shorlander, what should the active colour be?

Comment 3

[Daniel Bodea [:danibodea]]

Hi, Mike, do you think we should insist on this? Re-request opinion from someone else or by other means of communication?

Comment 4

[Mike Conley (:mconley) (:⚙️)]

I don't think we should block on this, but we'll keep it in the backlog.

Comment 5

[BugBot [:suhaib / :marco/ :calixte]]

Clear a needinfo that is pending on an inactive user.

Inactive users most likely will not respond; if the missing information is essential and cannot be collected another way, the bug maybe should be closed as INCOMPLETE.

For more information, please visit auto_nag documentation.