1640211 - Some cleanup around MCall in Ion

Status: RESOLVED FIXED

(Core :: JavaScript Engine: JIT, task)

Description

[Tom S. (please needinfo tschuster)]

There is some cleanup we should be doing in preparation for adding optimized scripted calls to Warp.

Comment 1

[Tom S. (please needinfo tschuster)]

Attachment: Bug 1640211 - Rename fun to callee in CallInfo. r?iain

The name is misleading, the callee doesn't have to be a function.

Comment 2

[Tom S. (please needinfo tschuster)]

Attachment: Bug 1640211 - Rename function to callee in MCall. r?iain

Depends on D76499

Comment 3

[Tom S. (please needinfo tschuster)]

Attachment: Bug 1640211 - Use js::FunctionFlags for WrappedFunction instead of manually defining bit-fields. r?tcampbell

We don't want to keep a pointer to the native or jitInfo, because that would mean in the long run we would have
to include those into CacheIR as well. (We are going to construct WrappedFunction off-main thread in the future
and initialize the flags explicitly via CacheIR, probably)

This also means fun_->jitInfo() is technically not thread-safe in debug mode, because of the isBuiltinNative() in hasJitInfo()

Depends on D76524

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/3738ba3a4c9a
Rename fun to callee in CallInfo. r=iain
https://hg.mozilla.org/integration/autoland/rev/37c1d57785f7
Rename function to callee in MCall. r=iain
https://hg.mozilla.org/integration/autoland/rev/d82fb36343f3
Use js::FunctionFlags for WrappedFunction instead of manually defining bit-fields. r=tcampbell

Comment 5

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/3738ba3a4c9a
https://hg.mozilla.org/mozilla-central/rev/37c1d57785f7
https://hg.mozilla.org/mozilla-central/rev/d82fb36343f3