1640300 - Warp: Transpile call/construct of scripted functions

Status: RESOLVED FIXED

(Core :: JavaScript Engine: JIT, task)

Comment 1

[Tom S. (please needinfo tschuster)]

Attachment: Bug 1640300 - Construct WrappedFunction based on new function metadata stored in CacheIR

Comment 2

[Tom S. (please needinfo tschuster)]

Attachment: Bug 1640300 - Factor out WarpCacheIRTranspiler::emitCallFunction

Depends on D76557

Comment 3

[Tom S. (please needinfo tschuster)]

Attachment: Bug 1640300 - Transpile scripted calls

Depends on D76558

Comment 4

[Tom S. (please needinfo tschuster)]

The final patch still has some XXX comments that need a second look, but I think nothing that is really a big concern. jit-tests seem to pass now.

The first patch is mostly concerned with trying to make sure we don't access JSFunction flags off-main thread. For that purposes I introduced a new CacheIR opcode GuardSpecificFunction, that we use to hold the nargs and flags besides the actual JSFunction pointer.

The actual code for scripted calls in WarpBuilderShared::makeCall is mostly borrowed from IonBuilder::makeCallHelper. We are still missing the code for optimizing |this| creation. There are also probably some minor optimization opportunities: Even if we don't have a monomorphic JSFunction target, we know if this is a native/scripted call. We could probabaly do disableArgCheck considering we don't have types, maybe this already happens though.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7ec7ea33770d
Construct WrappedFunction based on new function metadata stored in CacheIR r=jandem
https://hg.mozilla.org/integration/autoland/rev/26347a69e6d5
Factor out WarpCacheIRTranspiler::emitCallFunction r=jandem
https://hg.mozilla.org/integration/autoland/rev/8697046d90f6
Transpile scripted calls r=jandem

Comment 6

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/mozilla-central/rev/7ec7ea33770d
https://hg.mozilla.org/mozilla-central/rev/26347a69e6d5
https://hg.mozilla.org/mozilla-central/rev/8697046d90f6