1640382 - CI busted: Exception: In job.run using u'mozharness-test'/u'generic-worker' for job u'test-macosx1014-64/debug-xpcshell-1': two or more values in the same group of exclusion 'optimization' @ data[u'test'][<optimization>]

Status: RESOLVED FIXED

(Thunderbird :: Build Config, defect, P1)

Description

[Treeherder Bug Filer]

Filed by: mkmelin [at] iki.fi
Parsed log: https://treeherder.mozilla.org/logviewer.html#?job_id=303466640&repo=comm-central
Full log: https://firefox-ci-tc.services.mozilla.com/api/queue/v1/task/NB7opdQBTfqBwLj3GbxV2w/runs/0/artifacts/public/logs/live_backing.log

---

Something from either https://hg.mozilla.org/mozilla-central/pushloghtml?changeset=bbcc193fe0f0389a417ab4e047dc62b4837bf6b1 or https://hg.mozilla.org/mozilla-central/pushloghtml?changeset=d6abd35b54ad39fa030217716b172fa9883bf3c8

Comment 1

[Magnus Melin [:mkmelin]]

https://hg.mozilla.org/mozilla-central/rev/ea7100e4708bf38dc6f9e3830d3f4deb853008c7 looks like a likely offender

Comment 2

[Intermittent Failures Robot]

1 failures in 4727 pushes (0.0 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• comm-central: 1

Platform breakdown:

• gecko-decision: 1

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1640382&startday=2020-05-18&endday=2020-05-24&tree=all

Comment 3

[Magnus Melin [:mkmelin]]

Andrew, any idea what we need to do here?

Comment 4

[Andrew Halberstadt [:ahal]]

This is happening because the task test-macosx1014-64/debug-xpcshell-1 has both a when.files-changed key, and a schedules-component key. As per the test_description_schema, these two keys are meant to be mutually exclusive:
https://searchfox.org/mozilla-central/rev/ea7f70dac1c5fd18400f6d2a92679777d4b21492/taskcluster/taskgraph/transforms/tests.py#527

This is probably a regression from bug 1639349. I think I see the solution.

Comment 5

[Andrew Halberstadt [:ahal]]

Note: c-c is the only place still using when in the test kind. You could switch those to use the SCHEDULES method (in moz.build) to be more consistent with m-c if you wanted. Though I'll be the first to admit SCHEDULES rules are pretty confusing :).

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/46848d1e9f8c
Temporarily remove when.files-changed optimisation from test tasks. rs=bustage-fix a=me

Comment 7

[Geoff Lankow (:darktrojan)]

Well that didn't work. It was fine on Try, but now there's another problem.

Comment 8

[Andrew Halberstadt [:ahal]]

Attachment: Bug 1640382 - [taskgraph] Don't try to set 'schedules-component' on tasks that use 'when.files-changed', r?gbrown

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0121316e9653
[taskgraph] Don't try to set 'schedules-component' on tasks that use 'when.files-changed', r=gbrown

Comment 10

[mac198442]

(In reply to Pulsebot from comment #6)

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/46848d1e9f8c
Temporarily remove when.files-changed optimisation from test tasks.
rs=bustage-fix a=me

Now that the fix for this is on autoland, should not this change be backed out to not cloud the issue when it gets merged to mozilla-central?

Comment 11

[Geoff Lankow (:darktrojan)]

Yes, but we'll do it when the fix is on mozilla-central.

Comment 12

[mac198442]

(In reply to Geoff Lankow (:darktrojan) from comment #11)

Yes, but we'll do it when the fix is on mozilla-central.

OK I did not realize that the workaround was at least working for nightlies.

Comment 13

[Razvan Maries]

https://hg.mozilla.org/mozilla-central/rev/0121316e9653

Comment 14

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/c89c7c44e8a3
Backed out changeset 46848d1e9f8c. rs+a=me

Comment 15

[Magnus Melin [:mkmelin]]

Thanks Andrew!

Comment 16

[Intermittent Failures Robot]

4 failures in 5458 pushes (0.001 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• comm-central: 4

Platform breakdown:

• gecko-decision: 4

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1640382&startday=2020-05-25&endday=2020-05-31&tree=all