1640390 - Get All New Messages icon poorly visible in dark mode

Status: RESOLVED FIXED

(Thunderbird :: Theme, defect)

Description

[Andreas]

Attachment: Get all new messages_dark theme.png

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/83.0.4103.61 Safari/537.36 Edg/83.0.478.37

Steps to reproduce:

Thunderbird is set to dark mode. Click the arrow next to the "Get messages" button.

Actual results:

The icon belonging to the "Get All New Messages" entry is poorly visible because it is a light grey on white background.

Expected results:

In light mode, the icon is black with a light background. However, when switching to dark mode, the color of the icon gets inverted although the background color doesn't change.
Either set the icon to remain dark or change the background color (which involves changing the account icon(s)).

Comment 1

[Andreas]

Attachment: Get all new messages_light theme.png

For comparison: icon in light mode

Comment 2

[Richard Marti (:Paenglab)]

Attachment: 1640390-button-getAllNewMsg-color.patch

We need to add the folderMenuItem class to set the correct fill colour and not inherit the fill from the toolbarbutton.

Comment 3

[Alessandro Castellani [:aleca]]

Comment on attachment 9151248 [details] [diff] [review]
1640390-button-getAllNewMsg-color.patch

Review of attachment 9151248 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good, thanks.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/fe40c0acb3f8
Add the folderMenuItem class to "Get All New Messages" menuitem to set the correct fill colour. r=aleca