Closed Bug 1640493 Opened 4 months ago Closed 4 months ago

Make toolbarbutton's dropmarker optional instead of inserted by default, to reduce CE costs of toolbarbuttons

Categories

(Toolkit :: XUL Widgets, task)

task

Tracking

()

RESOLVED FIXED
mozilla78
Tracking Status
firefox78 --- fixed

People

(Reporter: Gijs, Assigned: Gijs)

References

Details

Attachments

(1 file)

Split off from bug 1639925 because the text/multiline-text thing is causing weird test issues in seemingly-unrelated code, and the dropmarker part is ready to land.

Pushed by gijskruitbosch@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/66cbc5a786e2
stop including dropmarkers in all toolbarbuttons, r=mak

This makes dropmarkers 'optional extras', effectively, and opts the existing
consumers I could find (the places window on macOS, and the 'more engines'
item in the search field popup) into these dropmarkers.

This allows removing all the CSS that was hiding these items in various
places.

We deliberately do not support adding dropmarkers at runtime. I also noticed
that the 'more engines' item already adds the 'badged' attribute after
connecting the node to the DOM, which may result in it not applying properly,
and fixed this.

Status: ASSIGNED → RESOLVED
Closed: 4 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla78
You need to log in before you can comment on or make changes to this bug.