Closed
Bug 1640493
Opened 4 years ago
Closed 4 years ago
Make toolbarbutton's dropmarker optional instead of inserted by default, to reduce CE costs of toolbarbuttons
Categories
(Toolkit :: UI Widgets, task)
Toolkit
UI Widgets
Tracking
()
RESOLVED
FIXED
mozilla78
Tracking | Status | |
---|---|---|
firefox78 | --- | fixed |
People
(Reporter: Gijs, Assigned: Gijs)
References
Details
Attachments
(1 file)
Split off from bug 1639925 because the text/multiline-text thing is causing weird test issues in seemingly-unrelated code, and the dropmarker part is ready to land.
Pushed by gijskruitbosch@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/66cbc5a786e2
stop including dropmarkers in all toolbarbuttons, r=mak
Assignee | ||
Comment 2•4 years ago
|
||
This makes dropmarkers 'optional extras', effectively, and opts the existing
consumers I could find (the places window on macOS, and the 'more engines'
item in the search field popup) into these dropmarkers.
This allows removing all the CSS that was hiding these items in various
places.
We deliberately do not support adding dropmarkers at runtime. I also noticed
that the 'more engines' item already adds the 'badged' attribute after
connecting the node to the DOM, which may result in it not applying properly,
and fixed this.
Comment 3•4 years ago
|
||
bugherder |
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla78
You need to log in
before you can comment on or make changes to this bug.
Description
•