1640010 - Port bug 1639925: Strip toolbarbutton inner DOM to the minimum required to reduce memory usage and CPU overhead

Status: RESOLVED FIXED

(Thunderbird :: Toolbars and Tabs, task)

Description

[Richard Marti (:Paenglab)]

Bug 1639925 changes how the dropmarkers are shown in toolbarbuttons. It also removes the toolbarbutton-multiline-text.

Comment 1

[Richard Marti (:Paenglab)]

Attachment: 1640010-add-dropmarker.patch

This fixes the dropmarkers.

But <toolbarbutton is="toolbarbutton-menu-button"> shows no text.

Magnus, please can you look what is needed to show the button text again? This needs probably a change in toolbarbutton-menu-button.js.

Comment 2

[Magnus Melin [:mkmelin]]

DIdn't try it yet, but looking at https://phabricator.services.mozilla.com/D76383 it removes
".toolbarbutton-text": "value=label
".toolbarbutton-multiline-text": "text=label

Not sure we use multiline anywhere. Anyway, we either would need to update callers to set set the label attribute directly (instead of value or text). Or add some mapping to inheritedAttributes https://searchfox.org/comm-central/rev/d492eaa594d697580eb7da55f2880acd9fd2fa7a/mail/base/content/toolbarbutton-menu-button.js#21. Prefeably update the callers I think.

Comment 3

[:Gijs (he/him)]

I've CC'd you as well, but just to be very explicit: I moved the dropmarker part to bug 1640493 and queued it for autoland. It looks from the comments here like you've already solved that issue, and this should give you more time on the text/multiline-text issue which is running into some weird toolkit test issues in non-toolbarbutton-related tests...

Comment 4

[Richard Marti (:Paenglab)]

Attachment: 1640010-add-dropmarker.patch

Updated the commit message to the new bug.

Comment 5

[Magnus Melin [:mkmelin]]

Comment on attachment 9151342 [details] [diff] [review]
1640010-add-dropmarker.patch

Review of attachment 9151342 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks Richard! r=mkmelin

Comment 6

[Magnus Melin [:mkmelin]]

Should land once bug 1640493 hits m-c

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/250b57b853c4
Port bug 1640493: Add the dropmarker back to our toolbarbuttons. r=mkmelin