Closed Bug 1640528 Opened 1 year ago Closed 1 year ago

`extension-storage` being present in `meta/global` causes syncs to fail

Categories

(Firefox :: Sync, task, P1)

task

Tracking

()

RESOLVED FIXED
Firefox 78
Tracking Status
firefox78 --- fixed

People

(Reporter: lina, Assigned: lina)

References

Details

Attachments

(1 file)

If extension-storage is mentioned in meta/global, either in engines or declined, syncing will try to set its enabled status. This currently throws an exception, because the engine doesn't currently have an enabled setter. We previously avoided this because extension-storage wasn't mentioned in m/g, but, with switching from Kinto to Sync, it is.

Complicating this is the fact that we tie extension storage to add-ons, but still allow opting in to it without syncing add-ons by setting an override pref.

By default, toggling the add-ons engine also toggles extension storage.
However, it's also possible to enable extension storage without add-ons
by setting an override pref. If the override pref is set, we'll treat
extension storage as an engine that can be toggled independently. If
it's not set, we'll ignore attempts to toggle the engine separately.

Pushed by mhammond@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/442f8bd2e723
Allow extension storage to be enabled and disabled independently of add-ons. r=markh
Status: ASSIGNED → RESOLVED
Closed: 1 year ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 78
You need to log in before you can comment on or make changes to this bug.