1640697 - MID filtering filters out RTX packets

Status: RESOLVED FIXED

(Core :: WebRTC: Signaling, defect, P1)

Description

[Dan Minor [:dminor]]

With MID filtering enabled, we drop RTX packets because they arrive with the same MID but a different ssrc. I didn't notice this in my initial testing because the first few RTX packets seem to make it through. We probably need to match against ssrc and payload type instead of just ssrc.

Comment 1

[Nils Ohlmeier [:drno]]

Or turn it into a list of SSRCs. Because as long as we know the MID we know to which m-section the RTP stream belongs to.

Comment 2

[Dan Minor [:dminor]]

Attachment: Bug 1640697 - Use set for MID bindings in MediaPipelineFilter; r=ng!

With RTX enabled, we have multiple SSRCs associated with a single MID, but the
filter code assumes that only one binding will be present. This change allows
a set of SSRCs to be associated with a MID.

Comment 3

[Dan Minor [:dminor]]

Attachment: Bug 1640697 - Test MID associated with multiple SSRCs; r=ng!

Depends on D76894

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/19790cba352a
Use set for MID bindings in MediaPipelineFilter; r=ng
https://hg.mozilla.org/integration/autoland/rev/a540f1bff6d1
Test MID associated with multiple SSRCs; r=ng

Comment 5

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/19790cba352a
https://hg.mozilla.org/mozilla-central/rev/a540f1bff6d1

Comment 6

[BugBot [:suhaib / :marco/ :calixte]]

The patch landed in nightly and beta is affected.
:dminor, is this bug important enough to require an uplift?
If not please set status_beta to wontfix.

For more information, please visit auto_nag documentation.

Comment 7

[Dan Minor [:dminor]]

Since RTX is disabled on 78 I don't think we need to uplift this.