Re-enable RTX with pref that disables it for broken sites
Categories
(Core :: WebRTC: Signaling, enhancement)
Tracking
()
Tracking | Status | |
---|---|---|
firefox79 | --- | fixed |
People
(Reporter: dminor, Assigned: dminor)
References
(Blocks 1 open bug)
Details
Attachments
(4 files)
RTX currently breaks Google Meet (See Bug 1638758). We'd like to enable RTX for sites where it works properly, so we'll need to add a pref to control which sites are allowed to use RTX. Before we can turn it back on, we need to fix Bug 1640697.
Assignee | ||
Comment 1•8 months ago
|
||
Assignee | ||
Comment 2•8 months ago
|
||
Depends on D77813
Assignee | ||
Comment 3•8 months ago
|
||
Depends on D77814
Updated•8 months ago
|
Updated•8 months ago
|
Pushed by dminor@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/86c2932e66d3 Add SetRtxIsAllowed method to JsepTrack and JsepSession; r=bwc https://hg.mozilla.org/integration/autoland/rev/249782af96bb Check RTX blocklist pref in PeerConnectionImpl; r=bwc https://hg.mozilla.org/integration/autoland/rev/41a85b7d3e5e Re-enable rtx and add *.google.com to blocklist; r=bwc
Comment 5•8 months ago
|
||
Backed out for failures at test_peerConnection_constructedStream.html
Backout link: https://hg.mozilla.org/integration/autoland/rev/dd3769eed4d11f8b4c6fdb3a5335d6f3302f9a03
Log link: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=305029654&repo=autoland&lineNumber=2472
https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=305026268&repo=autoland&lineNumber=46589
Assignee | ||
Comment 6•8 months ago
|
||
Yay, yet another backout because tests don't run on Android hardware on try by default.
Assignee | ||
Comment 7•8 months ago
|
||
With RTX and transport-cc enabled, it is possible to send padding packets prior
to any media being sent (see comments in RTPSender::SendPadData). But padding
bytes are counted separate from payload bytes and so do not show up in
bytesSent, which means that is possible that we've sent packets, but not bytes,
as far as the stats are concerned. This leads to frequent intermittent failures
while running tests on Android hardware.
Depends on D77815
Pushed by dminor@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/b6cc21d51827 Add SetRtxIsAllowed method to JsepTrack and JsepSession; r=bwc https://hg.mozilla.org/integration/autoland/rev/173f863893da Check RTX blocklist pref in PeerConnectionImpl; r=bwc https://hg.mozilla.org/integration/autoland/rev/edcc03ec3ea0 Re-enable rtx and add *.google.com to blocklist; r=bwc https://hg.mozilla.org/integration/autoland/rev/297d2efe3bb8 Remove check that bytesSent >= packetsSent in pc.js; r=ng
Comment 9•8 months ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/b6cc21d51827
https://hg.mozilla.org/mozilla-central/rev/173f863893da
https://hg.mozilla.org/mozilla-central/rev/edcc03ec3ea0
https://hg.mozilla.org/mozilla-central/rev/297d2efe3bb8
Description
•