1640766 - Make nsGlobalWindowInner::Suspend/Resume work for nested in-process modal event loops in fission world

Status: RESOLVED FIXED

(Core :: DOM: Window and Location, defect, P2)

Comment 1

[Hiroyuki Ikezoe (:hiro)]

These functions are also used for session history.

Comment 2

[Nika Layzell [:nika] (ni? for response)]

The BFCache case can probably be handled separately, by calling nsGlobalWindowInner::Suspend/Resume in every process when the document enters the BFCache, and can be fixed in a separate bug.

We should probably make sure that we handle cases like a.com -iframe> b.com -iframe> a.com by suspending/resuming both a.com frames.

Comment 3

[Chris Peterson [:cpeterson]]

This bug doesn't need to block Fission Nightly. Tracking for Fission riding the trains to Beta (M7).

Comment 4

[Neha Kochar [:neha]]

Jens, can someone from the DOM Core team work on this?

Comment 5

[Edgar Chen [:edgar]]

(In reply to Nika Layzell [:nika] (ni? for response) from comment #2)

We should probably make sure that we handle cases like a.com -iframe> b.com -iframe> a.com by suspending/resuming both a.com frames.

nsGlobalWindowInner::Suspend/Resume has already suspended/resumed all in-process child in

• https://searchfox.org/mozilla-central/rev/26330a08b1f9d06938faa0aa5e0f8c7a58064aa2/dom/base/nsGlobalWindowInner.cpp#5462
• https://searchfox.org/mozilla-central/rev/26330a08b1f9d06938faa0aa5e0f8c7a58064aa2/dom/base/nsGlobalWindowInner.cpp#5509

Nika, do we need to do something more in this bug? Thanks!

Comment 6

[Nika Layzell [:nika] (ni? for response)]

(In reply to Edgar Chen [:edgar] from comment #5)

(In reply to Nika Layzell [:nika] (ni? for response) from comment #2)

We should probably make sure that we handle cases like a.com -iframe> b.com -iframe> a.com by suspending/resuming both a.com frames.

nsGlobalWindowInner::Suspend/Resume has already suspended/resumed all in-process child in

• https://searchfox.org/mozilla-central/rev/26330a08b1f9d06938faa0aa5e0f8c7a58064aa2/dom/base/nsGlobalWindowInner.cpp#5462
• https://searchfox.org/mozilla-central/rev/26330a08b1f9d06938faa0aa5e0f8c7a58064aa2/dom/base/nsGlobalWindowInner.cpp#5509

Nika, do we need to do something more in this bug? Thanks!

That method doesn't handle cases such as the one which I mention in my comment, as CallOnAllInProcessChildren won't recurse into in-process subframes of out-of-process subframes. IIRC fixing that behaviour to correctly freeze everything in the same window agent is the purpose of this bug.

Comment 7

[Edgar Chen [:edgar]]

Yeah, right. Thanks!

Comment 8

[Edgar Chen [:edgar]]

Attachment: Bug 1640766 - Make nsGlobalWindowInner::Suspend/Resume suspend/resume all in-process descendants;

Comment 9

[Edgar Chen [:edgar]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=6cd39ca747631efa6c9a4ac848bd89f2e265bba7

Comment 10

[Edgar Chen [:edgar]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=f9a84e920703e7292ba97c490c58e10e5fa0600d

Comment 11

[Edgar Chen [:edgar]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=16793054b66c87ce0b5571f23b2192785c97f5d6

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/86d897662d5a
Make nsGlobalWindowInner::Suspend/Resume suspend/resume all in-process descendants; r=smaug

Comment 13

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/86d897662d5a