Closed
Bug 1640826
Opened 5 years ago
Closed 5 years ago
Broken build in /dom/media/MediaDecoderStateMachine.cpp if MOZ_GECKO_PROFILER is not defined
Categories
(Core :: Audio/Video: Playback, defect, P3)
Tracking
()
RESOLVED
FIXED
mozilla78
| Tracking | Status | |
|---|---|---|
| firefox-esr68 | --- | unaffected |
| firefox76 | --- | unaffected |
| firefox77 | --- | unaffected |
| firefox78 | --- | fixed |
People
(Reporter: msirringhaus, Assigned: alwu)
References
(Blocks 1 open bug, Regression)
Details
(Keywords: regression)
Attachments
(1 file)
MDSM_ERROR_MARKER is defined to take 3 arguments, if MOZ_GECKO_PROFILER is defined, and 2 if it is not defined.
It is, however, always used with 3 arguments, causing a broken build if MOZ_GECKO_PROFILER is not defined (https://searchfox.org/mozilla-central/source/dom/media/MediaDecoderStateMachine.cpp#3471).
Thank you for the report.
Alastor, could you please have a look?
|
||
Updated•5 years ago
|
Has Regression Range: --- → yes
|
||
Updated•5 years ago
|
Keywords: regression
|
|
||
Comment 2•5 years ago
|
||
Set release status flags based on info from the regressing bug 1612557
status-firefox76:
--- → unaffected
status-firefox77:
--- → unaffected
|
Assignee | |
Comment 3•5 years ago
|
||
Sorry for that, will fix this issue.
Assignee: nobody → alwu
Severity: -- → S4
Flags: needinfo?(alwu)
Priority: -- → P3
|
|
Assignee | |
Comment 4•5 years ago
|
||
MDSM_ERROR_MARKER should take 3 arguments, and we miss the last argument when MOZ_GECKO_PROFILE is not defined.
Pushed by alwu@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/9ffcb33b08ed
fix marco error r=bryce
|
||
Comment 6•5 years ago
|
||
| bugherder | ||
Status: UNCONFIRMED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla78
|
||
Updated•5 years ago
|
status-firefox-esr68:
--- → unaffected
You need to log in
before you can comment on or make changes to this bug.
Description
•