1640835 - Intermittent Last test finished | application crashed [@ mozilla::layers::APZThreadUtils::AssertOnControllerThread()]

Status: RESOLVED FIXED

(Core :: Panning and Zooming, defect)

Description

[Treeherder Bug Filer]

Filed by: kgupta [at] mozilla.com
Parsed log: https://treeherder.mozilla.org/logviewer.html#?job_id=303693230&repo=try
Full log: https://firefox-ci-tc.services.mozilla.com/api/queue/v1/task/EEJgRbicQxGi54NzOjhMeQ/runs/1/artifacts/public/logs/live_backing.log
Reftest URL: https://hg.mozilla.org/mozilla-central/raw-file/tip/layout/tools/reftest/reftest-analyzer.xhtml#logurl=https://firefox-ci-tc.services.mozilla.com/api/queue/v1/task/EEJgRbicQxGi54NzOjhMeQ/runs/1/artifacts/public/logs/live_backing.log&only_show_unexpected=1

---

Saw this a couple of times on try pushes. Probably a regression from bug 1635001. Shouldn't be user-impacting as it's just an assertion failure because a main-thread timeout task triggers after/during the ClearOnShutdown that's clearing the sControllerThread pointer.

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1635001

Comment 2

[Intermittent Failures Robot]

1 failures in 5458 pushes (0.0 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• try: 1

Platform breakdown:

• android-em-7-0-x86_64: 1

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1640835&startday=2020-05-25&endday=2020-05-31&tree=all

Comment 3

[Intermittent Failures Robot]

3 failures in 4949 pushes (0.001 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• try: 3

Platform breakdown:

• android-em-7-0-x86_64-qr: 3

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1640835&startday=2020-06-01&endday=2020-06-07&tree=all

Comment 4

[Intermittent Failures Robot]

2 failures in 5265 pushes (0.0 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• try: 2

Platform breakdown:

• android-em-7-0-x86_64: 2

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1640835&startday=2020-07-06&endday=2020-07-12&tree=all

Comment 5

[Andreea Pavel [:apavel]]

Retriggers: https://treeherder.mozilla.org/#/jobs?repo=autoland&searchStr=Android%2C7.0%2Cx86-64%2CWebRender%2Cdebug%2CMochitests%2Ctest-android-em-7.0-x86_64-qr%2Fdebug-geckoview-mochitest-plain-e10s%2C4&group_state=expanded&fromchange=db090162113b817aab48a425f64b12b96d7fda51&tochange=fe71d126d639dbf96e6b5b87a3cc33c0fb9d0676&selectedTaskRun=cRWVMGqpRuC-NZg5Musx1Q.0

Dan can you take a look if this is really from Bug 976669?

Comment 6

[Intermittent Failures Robot]

16 failures in 4014 pushes (0.004 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• autoland: 15
• mozilla-central: 1

Platform breakdown:

• android-em-7-0-x86_64-qr: 13
• android-em-7-0-x86_64: 3

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1640835&startday=2020-07-13&endday=2020-07-19&tree=all

Comment 7

[Dan Minor [:dminor]]

I think this is an existing intermittent. Bug 976669 added code to the about:webrtc page. I checked, and there aren't any unit tests which open that page, so my changes should not have had any effect on testing. The bug mentioned above (Bug 1635001) seems like a more likely cause of this.

Comment 8

[Hiroyuki Ikezoe (:hiro)]

I was hit by this assertion on one of my try runs, so I asked about it Botond in APZ channel on Matrix. He suggested to add a check whether sControllerThread is null or not at the top of InputQueue::MainThreadTimeout.

Comment 9

[Intermittent Failures Robot]

31 failures in 4310 pushes (0.007 failures/push) were associated with this bug in the last 7 days.

This is the #41 most frequent failure this week.

** This failure happened more than 30 times this week! Resolving this bug is a high priority. **

** Try to resolve this bug as soon as possible. If unresolved for 2 weeks, the affected test(s) may be disabled. **

Repository breakdown:

• autoland: 24
• mozilla-central: 6
• try: 1

Platform breakdown:

• android-em-7-0-x86_64-qr: 25
• android-em-7-0-x86_64: 6

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1640835&startday=2020-07-20&endday=2020-07-26&tree=all

Comment 10

[Andreea Pavel [:apavel]]

(In reply to Hiroyuki Ikezoe (:hiro) from comment #8)

I was hit by this assertion on one of my try runs, so I asked about it Botond in APZ channel on Matrix. He suggested to add a check whether sControllerThread is null or not at the top of InputQueue::MainThreadTimeout.

Hi, Hiroyuki. Who can make that change? Can you please set a ni?

Comment 11

[Hiroyuki Ikezoe (:hiro)]

I can take this.

Comment 12

[Andreea Pavel [:apavel]]

Thanks!

Comment 13

[Hiroyuki Ikezoe (:hiro)]

Attachment: Bug 1640835 - Bail out early from InputQueue::MainThreadTimeout if sControllerThread has been already discarded. r?botond

Comment 14

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/45894a26e9b1
Bail out early from InputQueue::MainThreadTimeout if sControllerThread has been already discarded. r=botond

Comment 15

[Alexandru Michis [:malexandru]]

https://hg.mozilla.org/mozilla-central/rev/45894a26e9b1

Comment 16

[Intermittent Failures Robot]

15 failures in 4289 pushes (0.003 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• autoland: 13
• mozilla-central: 2

Platform breakdown:

• android-em-7-0-x86_64-qr: 7
• android-em-7-0-x86_64: 8

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1640835&startday=2020-07-27&endday=2020-08-02&tree=all