1640867 - Record TRR steering telemetry separately

Status: RESOLVED FIXED

(Core :: Networking: DNS, enhancement, P1)

Comment 1

[Valentin Gosu [:valentin] (he/him)]

Attachment: Bug 1640867 - Record TRR steering telemetry separately r=dragana!,tdsmith!

This change makes a set of probes keyed. The key is "(default)" if no steering
is currently active, or "(auto-detected)" is the current URL has been set
by steering (autodetection).

Comment 2

[Valentin Gosu [:valentin] (he/him)]

Attachment: Bug 1640867 - Add new HTTP_CHANNEL_ONSTART_SUCCESS_TRR probe r=dragana!,tdsmith!

Depends on D77022

Comment 3

[Valentin Gosu [:valentin] (he/him)]

Attachment: request.md

Comment 4

[Tim Smith (inactive) 👨‍🔬 [:tdsmith]]

Comment on attachment 9152339 [details]
request.md

1) Is there or will there be **documentation** that describes the schema for the ultimate data set in a public, complete, and accurate way?

Yes, in Histograms.json and the probe dictionary.

2) Is there a control mechanism that allows the user to turn the data collection on and off?

Yes, the Firefox telemetry opt-out.

3) If the request is for permanent data collection, is there someone who will monitor the data over time?

Yes, Valentin.

4) Using the **[category system of data types](https://wiki.mozilla.org/Firefox/Data_Collection)** on the Mozilla wiki, what collection type of data do the requested measurements fall under?

Category 1, technical data.

5) Is the data collection request for default-on or default-off?

Default-on.

6) Does the instrumentation include the addition of **any *new* identifiers** (whether anonymous or otherwise; e.g., username, random IDs, etc.  See the appendix for more details)?

No.

7) Is the data collection covered by the existing Firefox privacy notice?

Yes.

8) Does there need to be a check-in in the future to determine whether to renew the data?

No, permanent collection.

9) Does the data collection use a third-party collection tool? 

No.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a4c770a70516
Record TRR steering telemetry separately r=dragana,tdsmith,necko-reviewers
https://hg.mozilla.org/integration/autoland/rev/75a1f56ff1ee
Add new HTTP_CHANNEL_ONSTART_SUCCESS_TRR probe r=dragana,tdsmith,necko-reviewers

Comment 6

[Dorel Luca [:dluca]]

Backed out 2 changesets (bug 1640867) for Network failures on multipe platforms. CLOSED TREE

Log:
https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=304336172&repo=autoland&lineNumber=1599

Push with failures:
https://treeherder.mozilla.org/#/jobs?repo=autoland&group_state=expanded&revision=75a1f56ff1ee5a201e0c58f54aca828e242f59c0

Backout:
https://hg.mozilla.org/integration/autoland/rev/367d792db84e4de844340fd51cb635957f2d412e

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e765628aee80
Record TRR steering telemetry separately r=dragana,tdsmith,necko-reviewers

Comment 8

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/e765628aee80

Comment 9

[Valentin Gosu [:valentin] (he/him)]

Comment on attachment 9152178 [details]
Bug 1640867 - Add new HTTP_CHANNEL_ONSTART_SUCCESS_TRR probe r=dragana!,tdsmith!

Beta/Release Uplift Approval Request

• User impact if declined: This was supposed to land in 78 along with the other patch.
  We'll be missing valuable telemetry for the TRR steering experiment
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky):
• String changes made/needed:

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/49241a6eadfe
Add new HTTP_CHANNEL_ONSTART_SUCCESS_TRR probe r=dragana,tdsmith,necko-reviewers

Comment 11

[Julien Cristau [:jcristau]]

(reopened so we can properly track the status in 78 including the second patch)

Comment 12

[Cristian Brindusan [:cbrindusan]]

https://hg.mozilla.org/mozilla-central/rev/49241a6eadfe

Comment 13

[Julien Cristau [:jcristau]]

Comment on attachment 9152178 [details]
Bug 1640867 - Add new HTTP_CHANNEL_ONSTART_SUCCESS_TRR probe r=dragana!,tdsmith!

add a telemetry probe, approved for 78.0b3

Comment 14

[Julien Cristau [:jcristau]]

https://hg.mozilla.org/releases/mozilla-beta/rev/dfa0b3855b9f