1640874 - Make the imAccounts dialog themeable

Status: RESOLVED FIXED

(Thunderbird :: Theme, task)

Description

[Richard Marti (:Paenglab)]

With the themeableDialog.css we can make the imAccounts dialog themeable relatively simple.

Comment 1

[Richard Marti (:Paenglab)]

Attachment: 1640874-imAccounts-themeable.patch

How about this?

Comment 2

[Alessandro Castellani [:aleca]]

Comment on attachment 9151717 [details] [diff] [review]
1640874-imAccounts-themeable.patch

Review of attachment 9151717 [details] [diff] [review]:
-----------------------------------------------------------------

Pretty good.
Just a couple of nits to fix.

::: mail/components/im/themes/imAccounts.css
@@ +58,5 @@
>  
>  #accountlist {
>    margin: 0;
>    -moz-appearance: none;
> +  border-block: 1px solid var(--splitter-color);

We shouldn't have a border top here as it double up with the border of the first item.

@@ +101,5 @@
>  
>  richlistitem[dragover="down"] {
>    border-bottom: 3px solid HighLight;
>  }
> +00

Typo?

Comment 3

[Richard Marti (:Paenglab)]

Attachment: 1640874-imAccounts-themeable.patch

(In reply to Alessandro Castellani (:aleca) from comment #2)

Comment on attachment 9151717 [details] [diff] [review]
1640874-imAccounts-themeable.patch

Review of attachment 9151717 [details] [diff] [review]:

Pretty good.
Just a couple of nits to fix.

::: mail/components/im/themes/imAccounts.css
@@ +58,5 @@

#accountlist {
margin: 0;
-moz-appearance: none;

• border-block: 1px solid var(--splitter-color);

We shouldn't have a border top here as it double up with the border of the
first item.

The richlistitems have no border. Only with dark theme there is a outline when focused.

@@ +101,5 @@

richlistitem[dragover="down"] {
border-bottom: 3px solid HighLight;
}
+00

Typo?

Yep.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/dba64c20e3a8
Make the imAccounts dialog themeable. r=aleca