Closed Bug 1640969 Opened 2 years ago Closed 2 years ago

Add startTime, and endTime to the marker struct

Categories

(Core :: Gecko Profiler, enhancement, P2)

enhancement

Tracking

()

RESOLVED FIXED
81 Branch
Tracking Status
firefox81 --- fixed

People

(Reporter: gregtatum, Assigned: gregtatum)

References

(Blocks 1 open bug)

Details

Attachments

(7 files)

Markers currently have a time field in the output JSON. Many markers in the payloads also include a startTime and endTime. These various fields end up being ambiguous in how they are used.

For the output marker table we should remove the time field, and add startTime and endTime. Each of these properties can then be null or number.

This will also need a profiler upgrader for the front-end which will need to land first.

Assignee: nobody → gtatum

This patch is the first step to our so-called "Markers 2.0" work. It's attempting to consolidate
some ad-hoc practices in the profiler into more solid practices. This is the first step to getting
the Gecko profiler to produce a format that has the timing information applied to the serialized
marker tuple, rather than a mix in the tuple and the payload.

The front-end merged, and once deployed this can be merged as well.

https://github.com/firefox-devtools/profiler/pull/2660

I'll be away from the office for a bit, so Nazim can help coordinate that, as he can deploy and was the reviewer for the front-end piece.

Pushed by gsquelart@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/b481d63c4ce1
Add Instant, Interval, IntervalStart, IntervalEnd markers to the profiler; r=gerald
https://hg.mozilla.org/integration/autoland/rev/702818e2e923
Remove startTime and endTime from most marker payloads; r=gerald
https://hg.mozilla.org/integration/autoland/rev/552a50d291d8
Update profiler gtests for startTime and endTime in markers; r=gerald
https://hg.mozilla.org/integration/autoland/rev/39429089fcf6
StoreMarker() doesn't need the TimeStamp argument anymore; r=canaltinova
https://hg.mozilla.org/integration/autoland/rev/0ced6d9dea69
Fix StoreMarkers calls from Android code; r=canaltinova
https://hg.mozilla.org/integration/autoland/rev/68d8385968bb
Ensure Tracing markers always have correct times and kind; r=canaltinova
https://hg.mozilla.org/integration/autoland/rev/baa47c1d4947
Fix gtests for tracing markers, and add PHASE tests; r=canaltinova
You need to log in before you can comment on or make changes to this bug.