Closed Bug 1641134 Opened 5 years ago Closed 5 years ago

`mach try chooser --pernosco` fails with KeyError: 'no_artifact'

Categories

(Developer Infrastructure :: Try, defect, P2)

Tracking

(firefox-esr68 unaffected, firefox76 unaffected, firefox77 unaffected, firefox78 wontfix, firefox79 fixed)

RESOLVED FIXED
mozilla79
Tracking Status
firefox-esr68 --- unaffected
firefox76 --- unaffected
firefox77 --- unaffected
firefox78 --- wontfix
firefox79 --- fixed

People

(Reporter: CuveeHsu, Assigned: ahal)

References

(Blocks 1 open bug, Regression)

Details

(Keywords: regression)

Attachments

(1 file)

I hit this error no matter that I set PYTHONDONTWRITEBYTECODE=1 or not.
I've been success two weeks ago.

./mach try chooser --pernosco
WARNING: You are using pip version 19.3.1; however, version 20.1.1 is available.
You should consider upgrading via the 'pip install --upgrade pip' command.
Error running mach:

['try', 'chooser', '--pernosco']

The error occurred in code that was called by the mach command. This is either
a bug in the called code itself or in the way that mach is calling it.
You can invoke |./mach busted| to check if this issue is already on file. If it
isn't, please use |./mach busted file| to report it. If |./mach busted| is
misbehaving, you can also inspect the dependencies of bug 1543241.

If filing a bug, please include the full output of mach, including this error
message.

The details of the failure are as follows:

KeyError: 'no_artifact'

File "/Users/jhsu/mozilla-central/tools/tryselect/mach_commands.py", line 327, in try_chooser
return self.run(**kwargs)
File "/Users/jhsu/mozilla-central/tools/tryselect/mach_commands.py", line 175, in run
kwargs = self.handle_try_config(**kwargs)
File "/Users/jhsu/mozilla-central/tools/tryselect/mach_commands.py", line 161, in handle_try_config
try_config = cls.try_config(**kwargs)
File "/Users/jhsu/mozilla-central/tools/tryselect/task_config.py", line 115, in try_config
if not kwargs['no_artifact'] and (kwargs['artifact'] or Artifact.is_artifact_build()):

python2 ./mach try chooser --pernosco works for me.

Regressed by: 1632429
Has Regression Range: --- → yes
Severity: -- → S2
Priority: -- → P2
Assignee: nobody → ahal
Status: NEW → ASSIGNED

Set release status flags based on info from the regressing bug 1632429

Pushed by ahalberstadt@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/69f1b1ffb252 [tryselect] Fix Python 3 compatibility issues with |mach try --pernosco|, r=mhentges
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla79

It works. Thanks!

The patch landed in nightly and beta is affected.
:ahal, is this bug important enough to require an uplift?
If not please set status_beta to wontfix.

For more information, please visit auto_nag documentation.

Flags: needinfo?(ahal)
Flags: needinfo?(ahal)
Product: Firefox Build System → Developer Infrastructure
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: