1641141 - error: no member named 'SetFollowLinks' in 'nsIFile'

Status: RESOLVED FIXED

(Thunderbird :: General, defect)

Description

[Richard Marti (:Paenglab)]

This comes from bug 1466532.

Comment 1

[Richard Marti (:Paenglab)]

Attachment: 1641141-remove-SetFollowLinks.patch

Port of https://hg.mozilla.org/mozilla-central/rev/04fe21d06acd

I only removed the lines like on https://hg.mozilla.org/mozilla-central/rev/04fe21d06acd#l3.12

The build is successful but it crashes on startup. I don't know if this is because of this patch.

Comment 2

[Magnus Melin [:mkmelin]]

Comment on attachment 9151981 [details] [diff] [review]
1641141-remove-SetFollowLinks.patch

Review of attachment 9151981 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks! r=mkmelin

::: mailnews/base/src/nsMsgFolderCompactor.cpp
@@ -327,5 @@
>    NS_ENSURE_SUCCESS(rv, rv);
>    m_file->InitWithFile(path);
> -  // need to make sure the temp file goes in the same real directory
> -  // as the original file, so resolve sym links.
> -  m_file->SetFollowLinks(true);

Just removing these would be a concern, but I see "XP_UNIX ignores SetFollowLinks" so I guess this was just not doing anything useful in the first place!!

Comment 3

[Richard Marti (:Paenglab)]

Also with the back-out of the m-c patch, and naturally my patch, does TB still crash.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/f9100b280c34
Port bug 1466532: Drop nsIFile::followLinks. r=mkmelin, a=me

Comment 5

[Magnus Melin [:mkmelin]]

I didn't yet build. Which platform are you crashing on?

Comment 6

[Richard Marti (:Paenglab)]

Windows. Also get the crash when building on m-c 4ff7fb7b9669. Looking further.