Closed Bug 1641280 Opened 1 year ago Closed 2 months ago

Enable Web Share by default on Windows Nightly

Categories

(Core :: DOM: Core & HTML, task, P3)

x86_64
Windows 10
task

Tracking

()

RESOLVED FIXED
92 Branch
Tracking Status
firefox92 --- fixed

People

(Reporter: saschanaz, Assigned: saschanaz)

References

Details

(Keywords: dev-doc-complete)

Attachments

(3 files)

The Windows May 2020 update is now generally available, which includes ShareCanceled API needed to track share cancellation.

Currently a caveat is that there is still no way to track selection of "Copy Link" feature, and doing so currently creates a promise that will never be resolved.

Depends on: 1573029
Severity: -- → N/A
Priority: -- → P3
Assignee: nobody → krosylight
Status: NEW → ASSIGNED

This feature has been deferred on Windows since Windows does not fire any DataPackage event when a user selects copy action from the OS dialog, potentially causing never-resolved promise. Windows still does not provide any other way to detect that action, even on Windows 11.

Per https://github.com/w3c/web-share/issues/188 Chromium gave up waiting user action and decided to immediately resolve the promise.

Given that Microsoft is not expected to fix the situation anytime soon, it's probably better to ship it in the form others have for feature parity.

Depends on D121420

Attachment #9234055 - Attachment description: Bug 1641280 - Part 2: Immediately resolve navigator.share on Windows r=smaug → Bug 1641280 - Part 2: Resolve WindowsUIUtils::Share without waiting action on Windows r=agashlin
Attachment #9234178 - Attachment description: Bug 1641280 - Part 3: Enable Web Share on Windows r=smaug → Bug 1641280 - Part 3: Enable Web Share on Windows for nightly/beta r=smaug
Pushed by krosylight@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/b183dae47176
Part 1: Fix lint warnings in WindowsUIUtils r=smaug
https://hg.mozilla.org/integration/autoland/rev/080107249a1c
Part 2: Resolve WindowsUIUtils::Share without waiting action on Windows r=smaug,agashlin
https://hg.mozilla.org/integration/autoland/rev/aa2915f66825
Part 3: Enable Web Share on Windows for nightly/beta r=smaug
Flags: needinfo?(krosylight)
Pushed by krosylight@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/ec4804b0afb3
Part 1: Fix lint warnings in WindowsUIUtils r=smaug
https://hg.mozilla.org/integration/autoland/rev/026a1eb28a9a
Part 2: Resolve WindowsUIUtils::Share without waiting action on Windows r=smaug,agashlin
https://hg.mozilla.org/integration/autoland/rev/4e731a3280df
Part 3: Enable Web Share on Windows for nightly/beta r=smaug
Flags: needinfo?(krosylight)
Status: ASSIGNED → RESOLVED
Closed: 2 months ago
Resolution: --- → FIXED
Target Milestone: --- → 92 Branch
You need to log in before you can comment on or make changes to this bug.