1641280 - Enable Web Share by default on Windows Nightly

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, task, P3)

Description

[Kagami Rosylight [:saschanaz] (they/them) (OOO until 2024-10-06)]

The Windows May 2020 update is now generally available, which includes ShareCanceled API needed to track share cancellation.

Currently a caveat is that there is still no way to track selection of "Copy Link" feature, and doing so currently creates a promise that will never be resolved.

Comment 1

[Kagami Rosylight [:saschanaz] (they/them) (OOO until 2024-10-06)]

Attachment: Bug 1641280 - Part 1: Fix lint warnings in WindowsUIUtils r=smaug

Comment 2

[Kagami Rosylight [:saschanaz] (they/them) (OOO until 2024-10-06)]

Attachment: Bug 1641280 - Part 2: Resolve WindowsUIUtils::Share without waiting action on Windows r=agashlin

This feature has been deferred on Windows since Windows does not fire any DataPackage event when a user selects copy action from the OS dialog, potentially causing never-resolved promise. Windows still does not provide any other way to detect that action, even on Windows 11.

Per https://github.com/w3c/web-share/issues/188 Chromium gave up waiting user action and decided to immediately resolve the promise.

Given that Microsoft is not expected to fix the situation anytime soon, it's probably better to ship it in the form others have for feature parity.

Depends on D121420

Comment 3

[Kagami Rosylight [:saschanaz] (they/them) (OOO until 2024-10-06)]

Attachment: Bug 1641280 - Part 3: Enable Web Share on Windows for nightly/beta r=smaug

Depends on D121421

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b183dae47176
Part 1: Fix lint warnings in WindowsUIUtils r=smaug
https://hg.mozilla.org/integration/autoland/rev/080107249a1c
Part 2: Resolve WindowsUIUtils::Share without waiting action on Windows r=smaug,agashlin
https://hg.mozilla.org/integration/autoland/rev/aa2915f66825
Part 3: Enable Web Share on Windows for nightly/beta r=smaug

Comment 5

[Alexandru Michis [:malexandru]]

Backed out 3 changesets (Bug 1641280) for causing bustages.
Backout link: https://hg.mozilla.org/integration/autoland/rev/3a298e8456aec9771c496387811326d1a3e3d278
Push with failures, failure log.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ec4804b0afb3
Part 1: Fix lint warnings in WindowsUIUtils r=smaug
https://hg.mozilla.org/integration/autoland/rev/026a1eb28a9a
Part 2: Resolve WindowsUIUtils::Share without waiting action on Windows r=smaug,agashlin
https://hg.mozilla.org/integration/autoland/rev/4e731a3280df
Part 3: Enable Web Share on Windows for nightly/beta r=smaug

Comment 7

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/ec4804b0afb3
https://hg.mozilla.org/mozilla-central/rev/026a1eb28a9a
https://hg.mozilla.org/mozilla-central/rev/4e731a3280df