Closed Bug 1641324 Opened 9 months ago Closed 9 months ago

Remove the layout.css.scrollbar-width.enabled and layout.css.scrollbar-color.enabled prefs.

Categories

(Core :: CSS Parsing and Computation, defect)

defect

Tracking

()

RESOLVED FIXED
mozilla79
Tracking Status
firefox79 --- fixed

People

(Reporter: emilio, Assigned: nilabja10201992, Mentored)

References

Details

(Keywords: good-first-bug, Whiteboard: [lang=c++][lang=rust])

Attachments

(5 files)

We've shipped these properties for a while, we should remove the runtime checks for them.

This involves removing all the references for these properties that aren't in generated code.

Given that this isn't necessarily causing any issues, and that it's marked as a good first bug with an assigned mentor, I am going to mark this with an S4 severity.

Severity: -- → S4

Hi, I would like to work on this, I am new to open source contribution, please let me know where to look at?

Sure, look at the search results for those prefs in searchfox (see this for scrollbar-width for example), and remove the references that aren't generated code, so the one in servo/components/style/properties/longhands/ui.mako.rs and modules/libpref/init/StaticPrefList.yaml, and the ones in tests.

Then run ./mach build, and ./mach devtools-css-db, and it should be done :)

(In reply to Emilio Cobos Álvarez (:emilio) from comment #3)

Sure, look at the search results for those prefs in searchfox (see this for scrollbar-width for example), and remove the references that aren't generated code, so the one in servo/components/style/properties/longhands/ui.mako.rs and modules/libpref/init/StaticPrefList.yaml, and the ones in tests.

Then run ./mach build, and ./mach devtools-css-db, and it should be done :)

Hi, I have pushed the changes (https://phabricator.services.mozilla.com/D78276)
Please review it, let me know in case changes aren't fine

Assignee: nobody → nilabja10201992
Status: NEW → ASSIGNED
Pushed by ealvarez@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/2b9a70901fd8
Remove the layout.css.scrollbar-width.enabled and layout.css.scrollbar-color.enabled prefs r=emilio
Status: ASSIGNED → RESOLVED
Closed: 9 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla79
Pushed by geoff@darktrojan.net:
https://hg.mozilla.org/comm-central/rev/e075d425fe1d
Port bug 1641324 - Remove the layout.css.scrollbar-width.enabled and layout.css.scrollbar-color.enabled prefs. rs=bustage-fix

Hey guys! Removing layout.css.scrollbar-color.enabled preference causes serious issue for me! Precise navigation in source code in developer tools are impossible without scrollbar arrows - bug 1579631

Also, I know designers want to have pretty scrollbars everywhere, but even here on bugzilla this colored scrollbar seriously reduces it's usability by blending with background - I have issues with locating where on the page I am.

Of course this can be causes by my bad eyesight or old monitor and you may not perceive it like this, but for me missing scrollbar arrows and scrollbar blending with background is a serious accessibility/usability issue!

Regressions: 1645676

Inability to disable these styling properties is causing scrollbars to look terrible and be effectively unusable from accessibility perspective across half of the www on Linux.

I would really appreciate it if they returned.

Does * { scrollbar-color: auto !important; scrollbar-width: auto !important; } on a user stylesheet not work? Seems like the usual mechanism to override the page's CSS.

Also, they should look better on Nightly fwiw, but let me know if you still find issues with them on Nightly and I can look into them.

You need to log in before you can comment on or make changes to this bug.