Closed Bug 1641403 Opened 4 years ago Closed 4 years ago

Re-enable C++ indexing for comm-central by having c-c generate metadata on taskcluster like m-c does

Categories

(Thunderbird :: Build Config, defect)

defect

Tracking

(thunderbird78 affected)

RESOLVED FIXED
Thunderbird 79.0
Tracking Status
thunderbird78 --- affected

People

(Reporter: jcranmer, Assigned: rjl)

References

(Blocks 1 open bug)

Details

Attachments

(4 files)

The code for searchfox assumes that comm-central is the topsrcdir and mozilla-central is a subdirectory of that. Ever since bug 1366607 landed, the configuration is reversed, with mozilla-central the top directory and comm-central a checkout contained in comm/. This configuration means that the build is failing, and comm-central is pretty reduced to just a plaintext search, which is far less helpful than it could be.

We haven't done builds for comm-central for much longer than that. It was disabled back in Nov 2017. So reversing the order of directories won't make any difference with respect to builds (because there aren't any) and will probably break permalinks and other things. I'm inclined to wontfix/invalid this bug, unless I'm missing something?

Huh, I didn't realize that builds were disabled so long ago. In that case, I'd rather this bug be about reenabling the C++ indexing for comm-central builds. It looks like Firefox moved to relying on taskcluster builds to create the metadata, so we'd have to add that for comm-central builds as well.

Retitling to reflect comment 2.

Summary: Update comm-central indexing on searchfox to account for bug 1366607 → Re-enable C++ indexing for comm-central by having c-c generate metadata on taskcluster like m-c does

The work here is mostly on the c-c side, i.e. adding support for the mozsearch clang-plugin if it doesn't already have it, and adding the taskcluster jobs that will generate the index. So moving this bug to a thunderbird component.

For copy/paste purposes here is the relevant stuff on the m-c side:

Component: Searchfox → Build Config
Product: Webtools → Thunderbird
Assignee: nobody → rob
Status: NEW → ASSIGNED

Depends on D80366

Set to run the same time as the Thunderbird Daily build.

Depends on D80367

Something else I forgot to mention in comment 4: if your builds use sccache to avoid recompiling object files, you'll want to disable that for the searchfox builds, otherwise it won't generate info for cache-hit files. In m-c that happens e.g. here.

We use those same mozharness config files for Thunderbird so sccache should be disabled.

I have a try job at: https://treeherder.mozilla.org/#/jobs?repo=try-comm-central&revision=2e5e65e1b1a566e5567b8f064e8dfbb8aafeec7a

artifact uploaded: target.mozsearch-distinclude.map
artifact uploaded: target.mozsearch-index.zip
artifact uploaded: target.mozsearch-rust-stdlib.zip
artifact uploaded: target.mozsearch-rust.zip

I didn't look at the files themselves to see if they look sane or not yet.

Pushed by thunderbird@calypsoblue.org:
https://hg.mozilla.org/comm-central/rev/d91208193b42
Add searchfox mozconfig files. r=darktrojan
https://hg.mozilla.org/comm-central/rev/5cedd5e3183b
Add searchfox kind to Thunderbird. r=darktrojan
https://hg.mozilla.org/comm-central/rev/e875fafd0467
Add Searchfox cron task. r=darktrojan

Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 79.0
Status: RESOLVED → REOPENED
Resolution: FIXED → ---

The actual searchfox_index method includes tasks that do not exist in the
Thunderbird taskgraph. Register a new method specific to Thunderbird that
includes only what is needed.

Attachment #9159572 - Attachment description: Bug 1641403 - Follow-up: Create target_task_method for Thunderbird Searchfox indexing. r=darktrojan → Bug 1641403 - Follow-up: Create target_task_method for Thunderbird Searchfox indexing. r=darktrojan DONTBUILD

Pushed by thunderbird@calypsoblue.org:
https://hg.mozilla.org/comm-central/rev/34cb186497fc
Follow-up: Create target_task_method for Thunderbird Searchfox indexing. r=darktrojan DONTBUILD

Status: REOPENED → RESOLVED
Closed: 4 years ago4 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: