Re-enable C++ indexing for comm-central by having c-c generate metadata on taskcluster like m-c does
Categories
(Thunderbird :: Build Config, defect)
Tracking
(thunderbird78 affected)
Tracking | Status | |
---|---|---|
thunderbird78 | --- | affected |
People
(Reporter: jcranmer, Assigned: rjl)
References
(Blocks 1 open bug)
Details
Attachments
(4 files)
The code for searchfox assumes that comm-central is the topsrcdir and mozilla-central is a subdirectory of that. Ever since bug 1366607 landed, the configuration is reversed, with mozilla-central the top directory and comm-central a checkout contained in comm/. This configuration means that the build is failing, and comm-central is pretty reduced to just a plaintext search, which is far less helpful than it could be.
Comment 1•4 years ago
|
||
We haven't done builds for comm-central for much longer than that. It was disabled back in Nov 2017. So reversing the order of directories won't make any difference with respect to builds (because there aren't any) and will probably break permalinks and other things. I'm inclined to wontfix/invalid this bug, unless I'm missing something?
Reporter | ||
Comment 2•4 years ago
|
||
Huh, I didn't realize that builds were disabled so long ago. In that case, I'd rather this bug be about reenabling the C++ indexing for comm-central builds. It looks like Firefox moved to relying on taskcluster builds to create the metadata, so we'd have to add that for comm-central builds as well.
Comment 3•4 years ago
|
||
Retitling to reflect comment 2.
Comment 4•4 years ago
|
||
The work here is mostly on the c-c side, i.e. adding support for the mozsearch clang-plugin if it doesn't already have it, and adding the taskcluster jobs that will generate the index. So moving this bug to a thunderbird component.
For copy/paste purposes here is the relevant stuff on the m-c side:
- The .cron.yml schedules the taskcluster jobs daily.
- The taskcluster jobs are like regular builds but with a few extra environment variables and a different mozconfig that enables rust analysis and the clang plugin
- Finally, there are some packaging steps to bundle up the analysis data and upload it as TC artifacts
Assignee | ||
Comment 5•4 years ago
|
||
Updated•4 years ago
|
Assignee | ||
Comment 6•4 years ago
|
||
Depends on D80366
Assignee | ||
Comment 7•4 years ago
|
||
Set to run the same time as the Thunderbird Daily build.
Depends on D80367
Comment 8•4 years ago
|
||
Assignee | ||
Comment 9•4 years ago
|
||
We use those same mozharness config files for Thunderbird so sccache should be disabled.
I have a try job at: https://treeherder.mozilla.org/#/jobs?repo=try-comm-central&revision=2e5e65e1b1a566e5567b8f064e8dfbb8aafeec7a
artifact uploaded: target.mozsearch-distinclude.map
artifact uploaded: target.mozsearch-index.zip
artifact uploaded: target.mozsearch-rust-stdlib.zip
artifact uploaded: target.mozsearch-rust.zip
I didn't look at the files themselves to see if they look sane or not yet.
Assignee | ||
Updated•4 years ago
|
Comment 10•4 years ago
|
||
Pushed by thunderbird@calypsoblue.org:
https://hg.mozilla.org/comm-central/rev/d91208193b42
Add searchfox mozconfig files. r=darktrojan
https://hg.mozilla.org/comm-central/rev/5cedd5e3183b
Add searchfox kind to Thunderbird. r=darktrojan
https://hg.mozilla.org/comm-central/rev/e875fafd0467
Add Searchfox cron task. r=darktrojan
Assignee | ||
Updated•4 years ago
|
Assignee | ||
Updated•4 years ago
|
Assignee | ||
Comment 11•4 years ago
|
||
The actual searchfox_index method includes tasks that do not exist in the
Thunderbird taskgraph. Register a new method specific to Thunderbird that
includes only what is needed.
Updated•4 years ago
|
Comment 12•4 years ago
|
||
Pushed by thunderbird@calypsoblue.org:
https://hg.mozilla.org/comm-central/rev/34cb186497fc
Follow-up: Create target_task_method for Thunderbird Searchfox indexing. r=darktrojan DONTBUILD
Updated•4 years ago
|
Description
•