1641412 - [Doorhanger V2] Collect all <input> values, pass to doorhanger

Status: RESOLVED FIXED

(Toolkit :: Password Manager, enhancement, P2)

Description

[:severin Rudie]

Sometimes we might guess wrong selecting <input>s from which to suggest login values. Collect all potential input values, classify them as more likely username or password, and pass them to the doorhanger so that any can be picked.

No functional change in this story, see {update with bug links once they've been opened}.

Technical notes -

• These values will need to be collected by the content process, passed to the parent, and then passed to the LoginManagerPrompter.jsm through promptToSavePassword and promptToChangePassword.
• Don't scan the DOM for inputs when the doorhanger opens. Instead, whenever an input is modified (we're already listening to this), cache it. Use that list when the doorhanger opens.
• Use LoginHelper.isPasswordFieldType and LoginHelper.isUsernameFieldType to classify inputs

Comment 1

[:severin Rudie]

Attachment: Bug 1641412 - Pass all possible UNs/PWs to doorhanger;r=MattN

Comment 2

[:severin Rudie]

Attachment: Bug 1641412 - temp commit, will be squashed. Test edge cases

Depends on D74181

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/85bbe760e98e
Pass all possible UNs/PWs to doorhanger;r=MattN,sfoster

Comment 4

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/85bbe760e98e