1641461 - Perma linux32 tier2 /webaudio/the-audio-api/the-convolvernode-interface/convolver-response-1-chan.html | X 5.1 chan downmix explicit: Channel 0 does not equal [random number]s

Status: RESOLVED FIXED

(Core :: Web Audio, defect, P5)

Description

[Treeherder Bug Filer]

Filed by: nerli [at] mozilla.com
Parsed log: https://treeherder.mozilla.org/logviewer.html#?job_id=304023394&repo=mozilla-central
Full log: https://firefox-ci-tc.services.mozilla.com/api/queue/v1/task/YzXNWP56RX2j3-EtMjINvw/runs/0/artifacts/public/logs/live_backing.log

---

[task 2020-05-27T23:28:43.447Z] 23:28:43 INFO - TEST-PASS | /webaudio/the-audio-api/the-convolvernode-interface/convolver-response-1-chan.html | 4 chan downmix explicit: Channel 1 equals [0,0,0.9692282676696777,0.8026211857795715,0.8825443387031555,0.1800812929868698,0.027644872665405273,-0.28447312116622925,-0.7766556143760681,-0.037477701902389526,-0.008235275745391846,0.07220339775085449,-0.33371710777282715,-0.7541776895523071,-0.0204334557056427,-0.03137746453285217...] with an element-wise tolerance of {"absoluteThreshold":4.76837158203125e-7,"relativeThreshold":0}.
[task 2020-05-27T23:28:43.448Z] 23:28:43 INFO - TEST-PASS | /webaudio/the-audio-api/the-convolvernode-interface/convolver-response-1-chan.html | < [4-channel input, explicit] All assertions passed. (total 2 assertions)
[task 2020-05-27T23:28:43.449Z] 23:28:43 INFO - TEST-PASS | /webaudio/the-audio-api/the-convolvernode-interface/convolver-response-1-chan.html | > [5.1-channel input, explicit] 5.1->2 explicit downmix producing 2-channel output
[task 2020-05-27T23:28:43.449Z] 23:28:43 INFO - TEST-UNEXPECTED-FAIL | /webaudio/the-audio-api/the-convolvernode-interface/convolver-response-1-chan.html | X 5.1 chan downmix explicit: Channel 0 does not equal [0,0,2.2955894470214844,2.0720269680023193,1.53206205368042,0.8335828185081482,-0.21171295642852783,-0.005277588963508606,0.8338429927825928,1.0169565677642822,0.3252672255039215,-0.6764179468154907,-1.0546464920043945,-0.5476447343826294,0.25095099210739136,-0.10892611742019653...] with an element-wise tolerance of {"absoluteThreshold":4.76837158203125e-7,"relativeThreshold":0}.
[task 2020-05-27T23:28:43.449Z] 23:28:43 INFO - Index Actual Expected AbsError RelError Test threshold
[task 2020-05-27T23:28:43.449Z] 23:28:43 INFO - [486] 2.2211096286773682e+0 2.2211103439331055e+0 7.1525573730468750e-7 3.2202620606328118e-7 4.7683715820312500e-7
[task 2020-05-27T23:28:43.449Z] 23:28:43 INFO - [511] 9.8628067970275879e-1 9.8628121614456177e-1 5.3644180297851563e-7 5.4390349749892017e-7 4.7683715820312500e-7
[task 2020-05-27T23:28:43.449Z] 23:28:43 INFO - [612] -1.3514937162399292e+0 -1.3514943122863770e+0 5.9604644775390625e-7 4.4102771453440351e-7 4.7683715820312500e-7
[task 2020-05-27T23:28:43.449Z] 23:28:43 INFO - [648] -8.9768998324871063e-2 -8.9769482612609863e-2 4.8428773880004883e-7 5.3947925810148448e-6 4.7683715820312500e-7
[task 2020-05-27T23:28:43.449Z] 23:28:43 INFO - [668] -1.4278178215026855e+0 -1.4278184175491333e+0 5.9604644775390625e-7 4.1745255589084416e-7 4.7683715820312500e-7
[task 2020-05-27T23:28:43.449Z] 23:28:43 INFO - ...and 1 more errors.
[task 2020-05-27T23:28:43.449Z] 23:28:43 INFO - Max AbsError of 7.1525573730468750e-7 at index of 486.
[task 2020-05-27T23:28:43.449Z] 23:28:43 INFO - Max RelError of 5.3947925810148448e-6 at index of 648.
[task 2020-05-27T23:28:43.449Z] 23:28:43 INFO - - assert_true: expected true got false
[task 2020-05-27T23:28:43.450Z] 23:28:43 INFO - _logFailed/<@http://web-platform.test:8000/webaudio/resources/audit.js:52:18
[task 2020-05-27T23:28:43.450Z] 23:28:43 INFO - Test.prototype.step@http://web-platform.test:8000/resources/testharness.js:1977:25
[task 2020-05-27T23:28:43.450Z] 23:28:43 INFO - test@http://web-platform.test:8000/resources/testharness.js:535:30
[task 2020-05-27T23:28:43.450Z] 23:28:43 INFO - _logFailed@http://web-platform.test:8000/webaudio/resources/audit.js:51:9
[task 2020-05-27T23:28:43.450Z] 23:28:43 INFO - _finalize@http://web-platform.test:8000/webaudio/resources/audit.js:217:19
[task 2020-05-27T23:28:43.450Z] 23:28:43 INFO - _assert@http://web-platform.test:8000/webaudio/resources/audit.js:230:12
[task 2020-05-27T23:28:43.450Z] 23:28:43 INFO - beCloseToArray@http://web-platform.test:8000/webaudio/resources/audit.js:1021:19
[task 2020-05-27T23:28:43.450Z] 23:28:43 INFO - downMixTest/<@http://web-platform.test:8000/webaudio/the-audio-api/the-convolvernode-interface/convolver-response-1-chan.html:341:16
[task 2020-05-27T23:28:43.450Z] 23:28:43 INFO - promise callbackdownMixTest@http://web-platform.test:8000/webaudio/the-audio-api/the-convolvernode-interface/convolver-response-1-chan.html:328:41
[task 2020-05-27T23:28:43.450Z] 23:28:43 INFO - @http://web-platform.test:8000/webaudio/the-audio-api/the-convolvernode-interface/convolver-response-1-chan.html:194:24
[task 2020-05-27T23:28:43.450Z] 23:28:43 INFO - run/<@http://web-platform.test:8000/webaudio/resources/audit.js:1195:27
[task 2020-05-27T23:28:43.450Z] 23:28:43 INFO - run@http://web-platform.test:8000/webaudio/resources/audit.js:1192:14
[task 2020-05-27T23:28:43.450Z] 23:28:43 INFO - run/<@http://web-platform.test:8000/webaudio/resources/audit.js:1341:34
[task 2020-05-27T23:28:43.450Z] 23:28:43 INFO - Test.prototype.step@http://web-platform.test:8000/resources/testharness.js:1977:25
[task 2020-05-27T23:28:43.450Z] 23:28:43 INFO - promise_test/tests.promise_tests</<@http://web-platform.test:8000/resources/testharness.js:592:36
[task 2020-05-27T23:28:43.450Z] 23:28:43 INFO - promise_test/tests.promise_tests<@http://web-platform.test:8000/resources/testharness.js:591:20
[task 2020-05-27T23:28:43.450Z] 23:28:43 INFO - promise callbackpromise_test@http://web-platform.test:8000/resources/testharness.js:590:51
[task 2020-05-27T23:28:43.450Z] 23:28:43 INFO - run@http://web-platform.test:8000/webaudio/resources/audit.js:1341:21
[task 2020-05-27T23:28:43.450Z] 23:28:43 INFO - @http://web-platform.test:8000/webaudio/the-audio-api/the-convolvernode-interface/convolver-response-1-chan.html:398:13
[task 2020-05-27T23:28:43.450Z] 23:28:43 INFO -
[task 2020-05-27T23:28:43.450Z] 23:28:43 INFO - TEST-UNEXPECTED-FAIL | /webaudio/the-audio-api/the-convolvernode-interface/convolver-response-1-chan.html | X 5.1 chan downmix explicit: Channel 1 does not equal [0,0,2.400212526321411,1.8464009761810303,1.2422339916229248,0.5788586139678955,0.3615038990974426,0.16441935300827026,-0.742911696434021,-1.530196189880371,-1.8989348411560059,-0.7277186512947083,0.010559797286987305,0.7105643153190613,1.748615026473999,0.26711004972457886...] with an element-wise tolerance of {"absoluteThreshold":4.76837158203125e-7,"relativeThreshold":0}.
[task 2020-05-27T23:28:43.450Z] 23:28:43 INFO - Index Actual Expected AbsError RelError Test threshold
[task 2020-05-27T23:28:43.450Z] 23:28:43 INFO - [162] 7.8881096839904785e-1 7.8881150484085083e-1 5.3644180297851563e-7 6.8006336074769486e-7 4.7683715820312500e-7
[task 2020-05-27T23:28:43.450Z] 23:28:43 INFO - [184] -1.1480939388275146e+0 -1.1480945348739624e+0 5.9604644775390625e-7 5.1916147115824401e-7 4.7683715820312500e-7
[task 2020-05-27T23:28:43.450Z] 23:28:43 INFO - [194] -5.8049070835113525e-1 -5.8049130439758301e-1 5.9604644775390625e-7 1.0267965139847631e-6 4.7683715820312500e-7
[task 2020-05-27T23:28:43.450Z] 23:28:43 INFO - Max AbsError of 5.9604644775390625e-7 at index of 184.
[task 2020-05-27T23:28:43.450Z] 23:28:43 INFO - Max RelError of 1.0267965139847631e-6 at index of 194.
[task 2020-05-27T23:28:43.450Z] 23:28:43 INFO - - assert_true: expected true got false
[task 2020-05-27T23:28:43.450Z] 23:28:43 INFO - _logFailed/<@http://web-platform.test:8000/webaudio/resources/audit.js:52:18
[task 2020-05-27T23:28:43.450Z] 23:28:43 INFO - Test.prototype.step@http://web-platform.test:8000/resources/testharness.js:1977:25
[task 2020-05-27T23:28:43.450Z] 23:28:43 INFO - test@http://web-platform.test:8000/resources/testharness.js:535:30
[task 2020-05-27T23:28:43.450Z] 23:28:43 INFO - _logFailed@http://web-platform.test:8000/webaudio/resources/audit.js:51:9
[task 2020-05-27T23:28:43.450Z] 23:28:43 INFO - _finalize@http://web-platform.test:8000/webaudio/resources/audit.js:217:19
[task 2020-05-27T23:28:43.450Z] 23:28:43 INFO - _assert@http://web-platform.test:8000/webaudio/resources/audit.js:230:12
[task 2020-05-27T23:28:43.450Z] 23:28:43 INFO - beCloseToArray@http://web-platform.test:8000/webaudio/resources/audit.js:1021:19
[task 2020-05-27T23:28:43.450Z] 23:28:43 INFO - downMixTest/<@http://web-platform.test:8000/webaudio/the-audio-api/the-convolvernode-interface/convolver-response-1-chan.html:343:16
[task 2020-05-27T23:28:43.450Z] 23:28:43 INFO - promise callbackdownMixTest@http://web-platform.test:8000/webaudio/the-audio-api/the-convolvernode-interface/convolver-response-1-chan.html:328:41
[task 2020-05-27T23:28:43.450Z] 23:28:43 INFO - @http://web-platform.test:8000/webaudio/the-audio-api/the-convolvernode-interface/convolver-response-1-chan.html:194:24
[task 2020-05-27T23:28:43.450Z] 23:28:43 INFO - run/<@http://web-platform.test:8000/webaudio/resources/audit.js:1195:27
[task 2020-05-27T23:28:43.450Z] 23:28:43 INFO - run@http://web-platform.test:8000/webaudio/resources/audit.js:1192:14
[task 2020-05-27T23:28:43.450Z] 23:28:43 INFO - run/<@http://web-platform.test:8000/webaudio/resources/audit.js:1341:34
[task 2020-05-27T23:28:43.450Z] 23:28:43 INFO - Test.prototype.step@http://web-platform.test:8000/resources/testharness.js:1977:25
[task 2020-05-27T23:28:43.450Z] 23:28:43 INFO - promise_test/tests.promise_tests</<@http://web-platform.test:8000/resources/testharness.js:592:36
[task 2020-05-27T23:28:43.450Z] 23:28:43 INFO - promise_test/tests.promise_tests<@http://web-platform.test:8000/resources/testharness.js:591:20
[task 2020-05-27T23:28:43.450Z] 23:28:43 INFO - promise callbackpromise_test@http://web-platform.test:8000/resources/testharness.js:590:51
[task 2020-05-27T23:28:43.450Z] 23:28:43 INFO - run@http://web-platform.test:8000/webaudio/resources/audit.js:1341:21
[task 2020-05-27T23:28:43.450Z] 23:28:43 INFO - @http://web-platform.test:8000/webaudio/the-audio-api/the-convolvernode-interface/convolver-response-1-chan.html:398:13
[task 2020-05-27T23:28:43.452Z] 23:28:43 INFO -
[task 2020-05-27T23:28:43.452Z] 23:28:43 INFO - TEST-FAIL | /webaudio/the-audio-api/the-convolvernode-interface/convolver-response-1-chan.html | < [5.1-channel input, explicit] 2 out of 2 assertions were failed. - assert_true: expected true got false
[task 2020-05-27T23:28:43.452Z] 23:28:43 INFO - _logFailed/<@http://web-platform.test:8000/webaudio/resources/audit.js:52:18
[task 2020-05-27T23:28:43.452Z] 23:28:43 INFO - Test.prototype.step@http://web-platform.test:8000/resources/testharness.js:1977:25
[task 2020-05-27T23:28:43.452Z] 23:28:43 INFO - test@http://web-platform.test:8000/resources/testharness.js:535:30
[task 2020-05-27T23:28:43.452Z] 23:28:43 INFO - _logFailed@http://web-platform.test:8000/webaudio/resources/audit.js:51:9
[task 2020-05-27T23:28:43.452Z] 23:28:43 INFO - done@http://web-platform.test:8000/webaudio/resources/audit.js:1227:19
[task 2020-05-27T23:28:43.452Z] 23:28:43 INFO - @http://web-platform.test:8000/webaudio/the-audio-api/the-convolvernode-interface/convolver-response-1-chan.html:201:34

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1640788

Comment 2

[James Graham [:jgraham]]

:padenot Is this another case where the web-audio tests are putting some varable data in the test name? If so the test is broken, since test names have to be unique. If the data is actually not variable we can update the metadata, but it would still be good to fix the naming to not involve serilizing an array of floats.

Comment 3

[Paul Adenot (:padenot)]

I think a patch from karl has been merged recently, I've seen something in my bugmail. Karl, is that something that you expect ?

Comment 4

[Karl Tomlinson (:karlt)]

Similar failures were being reported as bug 1620237, but changes for bug 1475158 have fixed "X 2" so now "5.1 chan downmix explicit" is at the top of the list.

I suspect this test was added after I wrote the changes for bug 1475158. I expect we can make this pass by using absoluteThreshold similarly.

This is a test where output data is in the test name as tracked in https://github.com/web-platform-tests/wpt/issues/10201.
Test names should be consistent on each platform, but differ between platforms.
Test names are unique because the output data is appended to a unique string.

I may have agreement from Raymond to remove the output data from the test names when the tests pass, but he was objecting to removal of output data from failing test names. (Yes, test names differ between pass and fail.)

I assume this is showing up on linux1804-32-shippable (and maybe windows10-aarch64) because the upstream test sync/pull doesn't regenerate expected results for these platforms?

Comment 5

[Intermittent Failures Robot]

21 failures in 5458 pushes (0.004 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• mozilla-central: 17
• autoland: 1
• try: 3

Platform breakdown:

• linux1804-32-shippable: 21

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1641461&startday=2020-05-25&endday=2020-05-31&tree=all

Comment 6

[Karl Tomlinson (:karlt)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=c5e9ed1ec51c5fcb268f6f64b944cce8debc181a

Comment 7

[Karl Tomlinson (:karlt)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=f4a66538874d05e8b2ae4ab9bafd7f63dedecf58

Comment 8

[Karl Tomlinson (:karlt)]

Attachment: Bug 1641461 use stereoResponseExplicitTest() for all 2-response convolver explicit channelCountMode tests r?padenot

and adjust description to match the downmixing to mono before convolution.

The previous use of stereoResponseTest(), which downmixed to stereo, for 5.1
only was inconsistent with other layouts and provides little additional
testing over the clamped-max test, which behaves the same for stereo
ConvolverNode input.

Comment 9

[Karl Tomlinson (:karlt)]

Attachment: Bug 1641461 generalize tolerances for convolver channelCountMode tests r?padenot

This is essentially a merge of
https://github.com/web-platform-tests/wpt/pull/11935 with
https://github.com/web-platform-tests/wpt/pull/21493.

For downMixTest() in convolver-response-1-chan.html, channelCount is 2 and so
channelCountMode: 'explicit' results are expected to match default
'clamped-max' results when the number of input channels is >= 2.

Coefficients for down-mixing 5.1 mean the maximum expected amplitude differs
between mono and stereo output as in convolver-response-2-chan.html.

Depends on D77969

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4676aa29469d
use stereoResponseExplicitTest() for all 2-response convolver explicit channelCountMode tests r=padenot
https://hg.mozilla.org/integration/autoland/rev/c990c7ac488d
generalize tolerances for convolver channelCountMode tests r=padenot

Comment 11

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/23967 for changes under testing/web-platform/tests

Comment 12

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

Upstream web-platform-tests status checks passed, PR will merge once commit reaches central.

Comment 13

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/4676aa29469d
https://hg.mozilla.org/mozilla-central/rev/c990c7ac488d

Comment 14

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

Upstream PR merged by moz-wptsync-bot