Closed Bug 1641514 Opened 4 months ago Closed 4 months ago

No text in toolbarbutton is="toolbarbutton-menu-button" after bug 1639925

Categories

(Thunderbird :: Toolbars and Tabs, defect)

defect

Tracking

(Not tracked)

RESOLVED FIXED
Thunderbird 78.0

People

(Reporter: Paenglab, Assigned: Paenglab)

References

Details

(Keywords: regression)

Attachments

(1 file)

Bug 1639925 changed the toolbarbutton-text. Since then the toolbarbutton is="toolbarbutton-menu-button", which is a TB own CE has no text.

The affected buttons are at least the "Get Messages" button in main window and in composer the "Spelling", "Security" and "Save" buttons.

So this wraps a non-menu-button toolbarbutton. I'm not familiar with this code, but at a glance, it looks like the issue is that the label/wrap used to be inherited from the parent element into the inner /nested toolbarbutton's .toolbarbutton-text via the inheritedAttributes which the c-c binding elides into its own inheritedAttributes. Now that the label isn't inherited via inheritedAttributes anymore, but via custom code in attributeChangedCallback, which calls this.getAttribute() to get the label value, we don't inherit the label/wrap from the "parent"/"outer" menu-button toolbarbutton into the inner toolbarbutton's text anymore.

I suspect adding label,wrap to https://searchfox.org/comm-central/rev/89c30dfce0f903bcab7e25e9a9f24f39988ef40c/mail/base/content/toolbarbutton-menu-button.js#25 so we inherit those from the outer to the inner toolbarbutton would fix this issue.

Many thanks Gijs for the hint. This works.

Assignee: nobody → richard.marti
Status: NEW → ASSIGNED
Attachment #9152383 - Flags: review?(mkmelin+mozilla)
Comment on attachment 9152383 [details] [diff] [review]
1641514-toolbarbutton-menu-button.patch

Review of attachment 9152383 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks! r=mkmelin
Attachment #9152383 - Flags: review?(mkmelin+mozilla) → review+
Target Milestone: --- → Thunderbird 78.0

Pushed by mkmelin@iki.fi:
https://hg.mozilla.org/comm-central/rev/1897e9e2fecb
Add label and wrap as inherited attributes to toolbarbutton-menu-button after bug 1639925. r=mkmelin

Status: ASSIGNED → RESOLVED
Closed: 4 months ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.