1641514 - No text in toolbarbutton is="toolbarbutton-menu-button" after bug 1639925

Status: RESOLVED FIXED

(Thunderbird :: Toolbars and Tabs, defect)

Description

[Richard Marti (:Paenglab)]

Bug 1639925 changed the toolbarbutton-text. Since then the toolbarbutton is="toolbarbutton-menu-button", which is a TB own CE has no text.

Comment 1

[Richard Marti (:Paenglab)]

The affected buttons are at least the "Get Messages" button in main window and in composer the "Spelling", "Security" and "Save" buttons.

Comment 2

[:Gijs (he/him)]

So this wraps a non-menu-button toolbarbutton. I'm not familiar with this code, but at a glance, it looks like the issue is that the label/wrap used to be inherited from the parent element into the inner /nested toolbarbutton's .toolbarbutton-text via the inheritedAttributes which the c-c binding elides into its own inheritedAttributes. Now that the label isn't inherited via inheritedAttributes anymore, but via custom code in attributeChangedCallback, which calls this.getAttribute() to get the label value, we don't inherit the label/wrap from the "parent"/"outer" menu-button toolbarbutton into the inner toolbarbutton's text anymore.

I suspect adding label,wrap to https://searchfox.org/comm-central/rev/89c30dfce0f903bcab7e25e9a9f24f39988ef40c/mail/base/content/toolbarbutton-menu-button.js#25 so we inherit those from the outer to the inner toolbarbutton would fix this issue.

Comment 3

[Richard Marti (:Paenglab)]

Attachment: 1641514-toolbarbutton-menu-button.patch

Many thanks Gijs for the hint. This works.

Comment 4

[Magnus Melin [:mkmelin]]

Comment on attachment 9152383 [details] [diff] [review]
1641514-toolbarbutton-menu-button.patch

Review of attachment 9152383 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks! r=mkmelin

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/1897e9e2fecb
Add label and wrap as inherited attributes to toolbarbutton-menu-button after bug 1639925. r=mkmelin