1641576 - Tabs API: port sendMessage() function from Firefox

Status: RESOLVED FIXED

(Thunderbird :: Add-Ons: Extensions API, enhancement)

Description

[Teal Dulcet [:tdulcet] (TB Council)]

There is no currently way to send messages to the compose scripts, for example when the user updates the options, as Thunderbird does not have an equivalent API to Firefox's browser.tabs.sendMessage(): https://developer.mozilla.org/en-US/docs/Mozilla/Add-ons/WebExtensions/API/tabs/sendMessage.

Comment 1

[Geoff Lankow (:darktrojan)]

Hmm, we don't have that function at all. Nor do we have browser.tabs.connect, which is related. I'm not sure if either are feasible.

Comment 2

[Geoff Lankow (:darktrojan)]

Attachment: Bug 1641576 - Tabs API: port sendMessage() function from Firefox. r?mkmelin

We actually had these functions, but they were not listed in the schema. I've updated the implementation to match Firefox's while here.

Comment 3

[Geoff Lankow (:darktrojan)]

Attachment: Bug 1641576 - Test content scripts on different types of tabs. r?mkmelin

Depends on D88369

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/8fbda33ac0ae
Tabs API: port sendMessage() function from Firefox. r=mkmelin
https://hg.mozilla.org/comm-central/rev/ec6c806b95ca
Test content scripts on different types of tabs. r=mkmelin

Comment 5

[Geoff Lankow (:darktrojan)]

Comment on attachment 9172311 [details]
Bug 1641576 - Tabs API: port sendMessage() function from Firefox. r?mkmelin

[Approval Request Comment]
User impact if declined: this is a core function of WX APIs that's been missing
Testing completed (on c-c, etc.): in beta 82
Risk to taking this patch (and alternatives if risky): low, it's just enabling stuff that already exists in firefox

Comment 6

[Geoff Lankow (:darktrojan)]

Comment on attachment 9172312 [details]
Bug 1641576 - Test content scripts on different types of tabs. r?mkmelin

[Approval Request Comment]
Just tests for the other patch.

Comment 7

[Geoff Lankow (:darktrojan)]

Attachment: 1641576-pt1-esr.diff

ESR version of the first patch.

[Approval Request Comment]
User impact if declined: this is a core function of WX APIs that's been missing
Testing completed (on c-c, etc.): in beta 82
Risk to taking this patch (and alternatives if risky): low, it's just enabling stuff that already exists in Firefox

Comment 8

[Wayne Mery (:wsmwk)]

Comment on attachment 9179822 [details] [diff] [review]
1641576-pt1-esr.diff

[Triage Comment]
Approved for esr78

Comment 9

[Wayne Mery (:wsmwk)]

Comment on attachment 9172312 [details]
Bug 1641576 - Test content scripts on different types of tabs. r?mkmelin

[Triage Comment]
Approved for esr78

Comment 10

[Rob Lemley [:rjl]]

Thunderbird 78.4.0:
https://hg.mozilla.org/releases/comm-esr78/rev/5d3bf7d7e39a
https://hg.mozilla.org/releases/comm-esr78/rev/55219ddffce7