1641581 - Provide Address Sanitizer builds of Thunderbird Daily

Status: RESOLVED FIXED

(Thunderbird :: Build Config, enhancement)

Description

[Teal Dulcet [:tdulcet] (TB Council)]

Provide Address Sanitizer (ASan) builds of Thunderbird Daily and port the ASan reporter add-on, to make fuzzing Thunderbird and reporting security vulnerabilities easier. Also see:

• https://bugzilla.mozilla.org/show_bug.cgi?id=863846
• https://blog.mozilla.org/security/2018/07/19/introducing-the-asan-nightly-project/
• https://firefox-source-docs.mozilla.org/tools/sanitizer/asan.html

Comment 1

[Rob Lemley [:rjl]]

Attachment: Bug 1641581 - Add Linux64 ASan build. r?darktrojan

Comment 2

[ISHIKAWA, Chiaki]

For what it's worth, I tried building ASAN build of DEBUG version of TB using GCC locally several weeks ago.
This was motivated due to the frustration of not being able to run mochitest under valgrind.
(|make mozmill| ran under valgrind and that helped me find many memory-related errors in the past including one that got me security bounty even.)

Specifically, there is a link time error caused by recently added OTR-related function.
Maybe I should report it if it is still there.
The added library function caused many other issues. So, I thought I would wait for the dust to settle down and would try again. Now that this bugzilla caught my eye, it is a good time to try again.
But I need to fix my local patches to cope with the massive format-only changes that landed in the last few days first.

Does the attached configuration change create ASAN build of TB on taskcluster (that uses clang)?
If so, maybe I should not bother to try creating GCC-based binary of ASAN TB.

TIA

Comment 3

[Rob Lemley [:rjl]]

(In reply to ISHIKAWA, Chiaki from comment #2)

Does the attached configuration change create ASAN build of TB on taskcluster (that uses clang)?

Yes it does, I'll get it landed today so that you can take a look at it.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/b0825b0c3b6b
Add Linux64 ASan build. r=darktrojan

Comment 5

[Rob Lemley [:rjl]]

The reporter addon will have to be covered in a separate bug, that's a pretty big project.
Other platforms can be built if there is desire and someone intends to make use of them.

Comment 6

[Teal Dulcet [:tdulcet] (TB Council)]

Should I create a new bug for porting the ASan reporter add-on?

I would be interested in (and would use) a Windows build. Firefox currently supports both Linux and Windows.

Comment 7

[Rob Lemley [:rjl]]

(In reply to tdulcet from comment #6)

Should I create a new bug for porting the ASan reporter add-on?
Yes please do.

I would be interested in (and would use) a Windows build. Firefox currently supports both Linux and Windows.

Great! I'll see what I can do.

Comment 8

[Rob Lemley [:rjl]]

Attachment: Bug 1641581 - Add Win64 ASan build. r=darktrojan

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/9406575de35e
Add Win64 ASan build. r=darktrojan

Comment 10

[Teal Dulcet [:tdulcet] (TB Council)]

Yes please do.

OK, I created Bug 1648731.

Great! I'll see what I can do.

Thanks for creating the Windows build! Where is the correct place to download both the Linux and Windows ASan builds? I am not seeing them listed with the other Daily/Nightly builds, although I can see that they are being built on Treeherder. Maybe these links should also be listed somewhere in the Developer documentation, like Firefox does.

Comment 11

[Magnus Melin [:mkmelin]]

On treeherder, click the B of the build, like https://treeherder.mozilla.org/#/jobs?repo=comm-central&selectedTaskRun=KMkcDbtNToG0CkmQMZFLUg.0 - then in the "Job details" below find the appropriate artifact to download.

Comment 12

[Teal Dulcet [:tdulcet] (TB Council)]

Attachment: error.png

OK, I downloaded the Windows installer, but I get this error during the installation and when I try to run Thunderbird afterwords. The installation completes, but Thunderbird does not open.

Comment 13

[Rob Lemley [:rjl]]

I'll take care of that. See bug 1646557.

Comment 14

[Teal Dulcet [:tdulcet] (TB Council)]

Bug 1646557 was marked as invalid two weeks ago and I am still getting this error.

Comment 15

[Rob Lemley [:rjl]]

That's not the right bug number. It's bug 1649557.
I've reopened it since it's not working as expected.