1641633 - Right-clicking with text selected breaks the selection

Status: NEW

(Core :: Widget: Gtk, defect, P2)

Description

[Gian-Carlo Pascutto [:gcp]]

STR:

1. Select some text on a web-page
2. Right click

Observed behavior:

Selection changes, selecting all text on the page

Expected:

Selection stays intact.

Regression from https://bugzilla.mozilla.org/show_bug.cgi?id=1552128

Ubuntu 18.04

Comment 1

[Martin Stránský [:stransky] (ni? me)]

I'll look at it. Do you have the system titlebar on or off?
Thanks.

Comment 2

[Martin Stránský [:stransky] (ni? me)]

I was testing that on xubuntu I did the fix for Bug 1552128 and also Ubuntu 18.04 with latest nightly with the titlebar on and off but I can't reproduce it anywhere.

Comment 3

[Martin Stránský [:stransky] (ni? me)]

Can you create a creencast of the issue for instance?

Comment 4

[Gian-Carlo Pascutto [:gcp]]

I'm using KDE FWIW. I'll get you a screenshot.

Comment 5

[Martin Stránský [:stransky] (ni? me)]

Okay I'll wait for it. I installed KDE on my 18.04 but I still can't reproduce it.

Comment 6

[Gian-Carlo Pascutto [:gcp]]

It doesn't reproduce any more :-/

It's weird because it was very reproducible and I bisected it directly to bug 1552128.

Looking closer there, it seems the fix for that bug landed in 2 parts, and possibly in 2 different Nightlies? Would having had a Nightly in-between both changesets have caused this?

Comment 7

[Martin Stránský [:stransky] (ni? me)]

(In reply to Gian-Carlo Pascutto [:gcp] from comment #6)

It doesn't reproduce any more :-/

It's weird because it was very reproducible and I bisected it directly to bug 1552128.

Looking closer there, it seems the fix for that bug landed in 2 parts, and possibly in 2 different Nightlies? Would having had a Nightly in-between both changesets have caused this?

The patches there was about wrong offset of popup windows but the selection stays even if you click outside the selection (at least what I see on all my test scenarios). But it's possible that particular site has a custom selection handler which checks mouse position.

Comment 8

[Gian-Carlo Pascutto [:gcp]]

But it's possible that particular site has a custom selection handler which checks mouse position.

I was seeing this even in Firefox's own pages (i.e. the startup page when you would launch a new profile).