1641727 - callbackProgress is missing a state argument

Status: RESOLVED FIXED

(Thunderbird :: Address Book, defect)

Description

[Ian Neal]

One of the calls to callbackProgress in the function verifyImage is missing an argument, at the moment it is callbackProgress(92) and I suspect the 92 is meant to be the percentage:
https://searchfox.org/comm-central/search?q=callbackProgress%28&path=&case=false&regexp=false
Not sure what the state needs to be passed, probably STATE_RESIZING but maybe STATE_TRANSFERRING.
As far as I can tell the state is not used anyway:
https://searchfox.org/comm-central/source/mail/components/addrbook/content/abCard.js#1141-1146

Comment 1

[Ian Neal]

Attachment: Add a state

Let's assume STATE_RESIZING is the correct state to be passing at this point.

Comment 2

[:aceman]

Comment on attachment 9152644 [details] [diff] [review]
Add a state

It looks like the 92 percentage is emptied when entering the verifyImage function and resizing is only done after that.
So it looks like semantically there should be some separate STATE_VERIFYING state, but I agree the state is ignored right now. Maybe it is a debugging feature.
So for now, I agree we could lump both percentages 92 and 95 under the same STATE_RESING state, the 2 cases are still distinguishable vie the percentage value.

The error reporting mechanism in this file still has some bug that it is not actually showing to the user if an error happens.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/a637a794de33
callbackProgress is missing a state argument. r=aceman