1641928 - Use new dump_syms for linux in CI

Status: RESOLVED FIXED

(Firefox Build System :: General, enhancement, P3)

Description

[Calixte Denizet (:calixte)]

Once this PR is merged:
https://github.com/mozilla/dump_syms/pull/91
we could use it in CI because this new version is a way faster.
For example with a libxul.so.dbg downloaded from symbols.m.o, the file is processed in ~2m10 with the old version and ~15s with the new version and the final file size is 20% smaller.

Comment 1

[Nathan Froyd [:froydnj]]

I am actively working on this.

Comment 2

[Nathan Froyd [:froydnj]]

Attachment: Bug 1641928 - permit DUMP_SYMS to be used when doing Linux builds; r=#build

Comment 3

[Nathan Froyd [:froydnj]]

Attachment: Bug 1641928 - use new dump_syms for Linux builds; r=#build

Faster and more maintainable is better.

Depends on D83653

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6d187a25138c
permit DUMP_SYMS to be used when doing Linux builds; r=firefox-build-system-reviewers,rstewart
https://hg.mozilla.org/integration/autoland/rev/07fdd9693d28
use new dump_syms for Linux builds; r=firefox-build-system-reviewers,rstewart

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/8b3e15e21d48
Add linux64-dump-syms to valgrind/kind.yml. r=froydnj CLOSED TREE

Comment 6

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/6d187a25138c
https://hg.mozilla.org/mozilla-central/rev/07fdd9693d28
https://hg.mozilla.org/mozilla-central/rev/8b3e15e21d48

Comment 7

[Alexandru Ionescu (needinfo me) [:alexandrui]]

Nathan, does the improvement below makes sense for this patch?
== Change summary for alert #26615 (as of Mon, 27 Jul 2020 10:52:53 GMT) ==

Improvements:

13% build times linux64 debug base-toolchains-clang taskcluster-c5d.4xlarge 1,848.93 -> 1,602.69
12% build times linux64 debug base-toolchains-clang taskcluster-c5d.4xlarge 1,853.41 -> 1,629.14
11% build times linux64 debug base-toolchains-clang taskcluster-c5.4xlarge 1,894.41 -> 1,694.59

For up to date results, see: https://treeherder.mozilla.org/perf.html#/alerts?id=26615

Comment 8

[Nathan Froyd [:froydnj]]

(In reply to Alexandru Ionescu (needinfo me) [:alexandrui] from comment #7)

Nathan, does the improvement below makes sense for this patch?
== Change summary for alert #26615 (as of Mon, 27 Jul 2020 10:52:53 GMT) ==

Improvements:

13% build times linux64 debug base-toolchains-clang taskcluster-c5d.4xlarge 1,848.93 -> 1,602.69
12% build times linux64 debug base-toolchains-clang taskcluster-c5d.4xlarge 1,853.41 -> 1,629.14
11% build times linux64 debug base-toolchains-clang taskcluster-c5.4xlarge 1,894.41 -> 1,694.59

For up to date results, see: https://treeherder.mozilla.org/perf.html#/alerts?id=26615

Yeah, that makes sense!