Closed Bug 1652870 Opened 3 months ago Closed 2 months ago

use new dump_syms for Android builds

Categories

(Firefox Build System :: General, task)

task

Tracking

(firefox80 fixed)

RESOLVED FIXED
mozilla80
Tracking Status
firefox80 --- fixed

People

(Reporter: froydnj, Assigned: froydnj)

References

Details

Attachments

(2 files)

No description provided.

It's not immediately obvious to me why we limit this check based on target;
I guess once upon a time there was no ELF or Mach-O support, so we wanted to
ensure people didn't shoot themselves in the foot. If that's the case,
testing indicates that Mach-O support isn't quite ready for prime-time and
we haven't got all the bits straightened out for our normal Linux builds.
So we're just going to enable it for Android here.

Faster and more maintainable is good.

Depends on D83560

Pushed by nfroyd@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/94ffbec77e89
permit DUMP_SYMS to be used when doing Android builds; r=mhentges
https://hg.mozilla.org/integration/autoland/rev/48a10a9249b0
use new dump_syms for Android builds; r=geckoview-reviewers,snorp
Pushed by nfroyd@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/0d8e1da6bb40
permit DUMP_SYMS to be used when doing Android builds; r=mhentges
https://hg.mozilla.org/integration/autoland/rev/c279e71779dc
use new dump_syms for Android builds; r=geckoview-reviewers,snorp
Status: NEW → RESOLVED
Closed: 3 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla80
Backout by csabou@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/fe71d126d639
Backed out 2 changesets for bustages on Android GeckoView multi-arch fat AAR.

Push with failures: https://treeherder.mozilla.org/#/jobs?repo=mozilla-central&group_state=expanded&resultStatus=testfailed%2Cbusted%2Cexception&revision=840f993400695f8c67d44b35f5f7f4b2c4bcf5fd&searchStr=Android%2C4.0%2CAPI16%2B%2CShippable%2CGeckoView%2Cmulti-arch%2Cfat%2CAAR%2Copt%2Cbuild-fat-aar-android-geckoview-fat-aar-shippable%2Fopt%2CBgv&selectedTaskRun=CrE_UrXWTxaUo9yQ75VEqw.0

Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=309879549&repo=mozilla-central&lineNumber=946

Backout link: https://hg.mozilla.org/integration/autoland/rev/fe71d126d639

[task 2020-07-15T17:58:47.717Z] 17:58:47     INFO -  checking for the Leanplum SDK key... no
[task 2020-07-15T17:58:47.717Z] 17:58:47     INFO -  checking for the Pocket API key... no
[task 2020-07-15T17:58:47.751Z] 17:58:47     INFO -  checking for dump_syms... not found
[task 2020-07-15T17:58:47.751Z] 17:58:47     INFO -  DEBUG: dump_syms: Trying /builds/worker/fetches/dump_syms/dump_syms
[task 2020-07-15T17:58:47.751Z] 17:58:47     INFO -  ERROR: Cannot find dump_syms
[task 2020-07-15T17:58:47.805Z] 17:58:47     INFO -  *** Fix above errors and then restart with\
[task 2020-07-15T17:58:47.805Z] 17:58:47     INFO -                 "./mach build"
[task 2020-07-15T17:58:47.805Z] 17:58:47     INFO -  make: *** [client.mk:115: configure] Error 1
[task 2020-07-15T17:58:47.862Z] 17:58:47    ERROR - Return code: 2
[task 2020-07-15T17:58:47.862Z] 17:58:47  WARNING - setting return code to 2
[task 2020-07-15T17:58:47.862Z] 17:58:47    FATAL - 'mach build -v' did not run successfully. Please check log for errors.
[task 2020-07-15T17:58:47.862Z] 17:58:47    FATAL - Running post_fatal callback...
[task 2020-07-15T17:58:47.862Z] 17:58:47    FATAL - Exiting -1
[task 2020-07-15T17:58:47.862Z] 17:58:47     INFO - [mozharness: 2020-07-15 17:58:47.862741Z] Finished build step (failed)
[task 2020-07-15T17:58:47.862Z] 17:58:47     INFO - Running post-run listener: _parse_build_tests_ccov
[task 2020-07-15T17:58:47.863Z] 17:58:47     INFO - Update channel set to: b'nightly'
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Target Milestone: mozilla80 → ---

I think this is just a matter of adding the linux64-dump-syms fetch here.

Pushed by nfroyd@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/e4cd31ea3ca1
permit DUMP_SYMS to be used when doing Android builds; r=mhentges
https://hg.mozilla.org/integration/autoland/rev/c27434336da3
use new dump_syms for Android builds; r=geckoview-reviewers,snorp
Status: REOPENED → RESOLVED
Closed: 3 months ago2 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla80
Regressions: 1654233
Flags: needinfo?(nfroyd)
You need to log in before you can comment on or make changes to this bug.