1652870 - use new dump_syms for Android builds

Status: RESOLVED FIXED

(Firefox Build System :: General, task)

Comment 1

[Nathan Froyd [:froydnj]]

Attachment: Bug 1652870 - permit DUMP_SYMS to be used when doing Android builds; r=#build

It's not immediately obvious to me why we limit this check based on target;
I guess once upon a time there was no ELF or Mach-O support, so we wanted to
ensure people didn't shoot themselves in the foot. If that's the case,
testing indicates that Mach-O support isn't quite ready for prime-time and
we haven't got all the bits straightened out for our normal Linux builds.
So we're just going to enable it for Android here.

Comment 2

[Nathan Froyd [:froydnj]]

Attachment: Bug 1652870 - use new dump_syms for Android builds; r=#build

Faster and more maintainable is good.

Depends on D83560

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/94ffbec77e89
permit DUMP_SYMS to be used when doing Android builds; r=mhentges
https://hg.mozilla.org/integration/autoland/rev/48a10a9249b0
use new dump_syms for Android builds; r=geckoview-reviewers,snorp

Comment 4

[Dorel Luca [:dluca]]

Backed out 2 changesets (bug 1652870) for Android bustage. CLOSED TREE

Log:
https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=309842343&repo=autoland&lineNumber=893

Push with failures:
https://treeherder.mozilla.org/#/jobs?repo=autoland&group_state=expanded&revision=48a10a9249b0ec8a3f1d7a630063af4ef17d2f54

Backout:
https://hg.mozilla.org/integration/autoland/rev/f2e006ca8c7cdf3a62995d122536c2fc6368640f

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0d8e1da6bb40
permit DUMP_SYMS to be used when doing Android builds; r=mhentges
https://hg.mozilla.org/integration/autoland/rev/c279e71779dc
use new dump_syms for Android builds; r=geckoview-reviewers,snorp

Comment 6

[Cristina Coroiu [:ccoroiu]]

https://hg.mozilla.org/mozilla-central/rev/0d8e1da6bb40
https://hg.mozilla.org/mozilla-central/rev/c279e71779dc

Comment 7

[Pulsebot]

Backout by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/fe71d126d639
Backed out 2 changesets for bustages on Android GeckoView multi-arch fat AAR.

Comment 8

[Cosmin Sabou [:CosminS]]

Push with failures: https://treeherder.mozilla.org/#/jobs?repo=mozilla-central&group_state=expanded&resultStatus=testfailed%2Cbusted%2Cexception&revision=840f993400695f8c67d44b35f5f7f4b2c4bcf5fd&searchStr=Android%2C4.0%2CAPI16%2B%2CShippable%2CGeckoView%2Cmulti-arch%2Cfat%2CAAR%2Copt%2Cbuild-fat-aar-android-geckoview-fat-aar-shippable%2Fopt%2CBgv&selectedTaskRun=CrE_UrXWTxaUo9yQ75VEqw.0

Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=309879549&repo=mozilla-central&lineNumber=946

Backout link: https://hg.mozilla.org/integration/autoland/rev/fe71d126d639

[task 2020-07-15T17:58:47.717Z] 17:58:47     INFO -  checking for the Leanplum SDK key... no
[task 2020-07-15T17:58:47.717Z] 17:58:47     INFO -  checking for the Pocket API key... no
[task 2020-07-15T17:58:47.751Z] 17:58:47     INFO -  checking for dump_syms... not found
[task 2020-07-15T17:58:47.751Z] 17:58:47     INFO -  DEBUG: dump_syms: Trying /builds/worker/fetches/dump_syms/dump_syms
[task 2020-07-15T17:58:47.751Z] 17:58:47     INFO -  ERROR: Cannot find dump_syms
[task 2020-07-15T17:58:47.805Z] 17:58:47     INFO -  *** Fix above errors and then restart with\
[task 2020-07-15T17:58:47.805Z] 17:58:47     INFO -                 "./mach build"
[task 2020-07-15T17:58:47.805Z] 17:58:47     INFO -  make: *** [client.mk:115: configure] Error 1
[task 2020-07-15T17:58:47.862Z] 17:58:47    ERROR - Return code: 2
[task 2020-07-15T17:58:47.862Z] 17:58:47  WARNING - setting return code to 2
[task 2020-07-15T17:58:47.862Z] 17:58:47    FATAL - 'mach build -v' did not run successfully. Please check log for errors.
[task 2020-07-15T17:58:47.862Z] 17:58:47    FATAL - Running post_fatal callback...
[task 2020-07-15T17:58:47.862Z] 17:58:47    FATAL - Exiting -1
[task 2020-07-15T17:58:47.862Z] 17:58:47     INFO - [mozharness: 2020-07-15 17:58:47.862741Z] Finished build step (failed)
[task 2020-07-15T17:58:47.862Z] 17:58:47     INFO - Running post-run listener: _parse_build_tests_ccov
[task 2020-07-15T17:58:47.863Z] 17:58:47     INFO - Update channel set to: b'nightly'

Comment 9

[Cosmin Sabou [:CosminS]]

Backout merged to central: https://hg.mozilla.org/mozilla-central/rev/fe71d126d639dbf96e6b5b87a3cc33c0fb9d0676

Comment 10

[Gabriele Svelto [:gsvelto] (PTO)]

I think this is just a matter of adding the linux64-dump-syms fetch here.

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e4cd31ea3ca1
permit DUMP_SYMS to be used when doing Android builds; r=mhentges
https://hg.mozilla.org/integration/autoland/rev/c27434336da3
use new dump_syms for Android builds; r=geckoview-reviewers,snorp

Comment 12

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/mozilla-central/rev/e4cd31ea3ca1
https://hg.mozilla.org/mozilla-central/rev/c27434336da3