1642219 - Add "Add-ons Support" to Thunderbird add-ons manager

Status: VERIFIED FIXED

(Thunderbird :: Add-Ons: General, defect, P1)

Description

[Wayne Mery (:wsmwk)]

Firefox has this - for some reason it is missing in Thunderbird. It would be good to have this for version 78. I assume it requires strings. NI Magnus to assign. NI Alex in case he has any concerns.

We need to point it somewhere. https://support.mozilla.org/en-US/kb/thunderbird-add-ons-frequently-asked-questions should be good enough for now. Although that KB cound stand to be improved.

Firefox's goes to https://support.mozilla.org/en-US/products/firefox/manage-preferences-and-add-ons-firefox/install-and-manage-add-ons?as=u&utm_source=inproduct

Comment 1

[Magnus Melin [:mkmelin]]

Strings are in toolkit. Looks like we're just hiding the button
https://searchfox.org/comm-central/rev/1caf86b49b044958fed0b0d8d5fb6ec974557aaa/mail/base/content/aboutAddonsExtra.css#28-31

Comment 2

[Magnus Melin [:mkmelin]]

Links to https://support.thunderbird.net/en-US/thunderbird/20200601150546/addons-help
That's from app.support.baseURL.

So if someone creates a page at the suitable URL we can unhide it.

Comment 3

[Alessandro Castellani [:aleca]]

I can take care of this if you want.
All agree to point that button to the URL Ways proposed?
https://support.mozilla.org/en-US/kb/thunderbird-add-ons-frequently-asked-questions

Comment 4

[Magnus Melin [:mkmelin]]

To avoid needless code to handle what url is used, we should create the corresponding url/redirect as firefox.
I think firefox also redirect - one ends up at https://support.mozilla.org/en-US/products/firefox/manage-preferences-and-add-ons-firefox/install-and-manage-add-ons?as=u&utm_source=inproduct

BTW, https://support.mozilla.org/en-US/kb/thunderbird-add-ons-frequently-asked-questions links to MDN add-on development at the bottom of the page. That should go to DTN.)

Comment 5

[Wayne Mery (:wsmwk)]

John and I discussed this yesterday in matrix

Comment 6

[Alessandro Castellani [:aleca]]

John, since you've been doing some great work on the Add-ons Manager, do you thin you would have time to take care of this?

Comment 7

[John Bieling (:TbSync)]

sure, just assign me.

Comment 8

[John Bieling (:TbSync)]

After bug 1623575 has landed, that link goes to:
https://support.thunderbird.net/thunderbird/{appver}/{os}/{locale}/addons-help

I created a PR to add the needed redirect:
https://github.com/thundernest/thundernest-ansible/pull/26

Comment 9

[John Bieling (:TbSync)]

Attachment: bug1642219_unhide_addons_support_button.patch

The pull request to add the redirect has been merged, so we can unhide the button now. It will take another day or two before the new setting becomes active.

Comment 10

[Alessandro Castellani [:aleca]]

Comment on attachment 9201873 [details] [diff] [review]
bug1642219_unhide_addons_support_button.patch

Review of attachment 9201873 [details] [diff] [review]:
-----------------------------------------------------------------

Nice, thanks. r=aleca

Comment 11

[John Bieling (:TbSync)]

The redirect is active. We can get this landed.

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/c34f619b584b
Unhide the Add-ons Support button. r=aleca

Comment 13

[John Bieling (:TbSync)]

Comment on attachment 9201873 [details] [diff] [review]
bug1642219_unhide_addons_support_button.patch

[Approval Request Comment]
Regression caused by (bug #):
User impact if declined:
No Support Link

Testing completed (on c-c, etc.):
Risk to taking this patch (and alternatives if risky):
Zero to none.

Comment 14

[Wayne Mery (:wsmwk)]

Comment on attachment 9201873 [details] [diff] [review]
bug1642219_unhide_addons_support_button.patch

[Triage Comment]
Approved for beta

Comment 15

[Rob Lemley [:rjl]]

Thunderbird 86.0b3:
https://hg.mozilla.org/releases/comm-beta/rev/4157c50998f0

Comment 16

[WaltS48 [:walts48]]

TB 86.0b3 on Windows 10

Comment 17

[Wayne Mery (:wsmwk)]

Comment on attachment 9201873 [details] [diff] [review]
bug1642219_unhide_addons_support_button.patch

[Triage Comment]
Approved for esr78

Comment 18

[Rob Lemley [:rjl]]

Thunderbird 78.8.0:
https://hg.mozilla.org/releases/comm-esr78/rev/825f532dba9e

Comment 19

[WaltS48 [:walts48]]

Works for me in my tests of the 78.8.0 release candidate on Fedora 33 Workstation and Windows 10.