Give a non-localised version of DDG to all locales
Categories
(SeaMonkey :: Search, defect)
Tracking
(seamonkey2.53+ fixed, seamonkey2.57esr? affected)
People
(Reporter: iannbugzilla, Assigned: iannbugzilla)
References
Details
(Whiteboard: SM2.53.3)
Attachments
(1 file, 1 obsolete file)
10.79 KB,
patch
|
frg
:
review+
frg
:
approval-comm-release+
frg
:
approval-comm-esr60+
|
Details | Diff | Splinter Review |
Localised versions of DDG override any setting user may have configured for region so, we should also ship a non-localised version in the list of available search engines.
[Approval Request Comment]
Regression caused by (bug #): 1636756
User impact if declined: Region setting is ignored for first search
Testing completed (on m-c, etc.): 2.53.3
Risk to taking this patch (and alternatives if risky): none
String changes made by this patch: none
Should we create a ddg-en-US and also ship ddg-all with en-US?
ka doesn't have a localised ddg (yet).
Changes since last patch:
- Now an en-US DDG search engine
- Description says Global rather than All for the non-localised version
Comment 3•4 years ago
|
||
Comment on attachment 9153252 [details] [diff] [review] Global DDG LGTM
Pushed by frgrahl@gmx.net:
https://hg.mozilla.org/comm-central/rev/5578dcf8959f
Give a non-localised version of DDG to all locales. r=frg
Comment 5•4 years ago
|
||
Target 2.53.3
https://gitlab.com/seamonkey-project/seamonkey-2.53-comm/-/commit/8560472b72fe7fc7f7c0671673003226cbe86fa6
Description
•