1642271 - Don't sync webextensions.storage.sync.kinto

Status: VERIFIED FIXED

(WebExtensions :: Storage, enhancement)

Description

[Mark Hammond (PTO; back Oct-3) [:markh] [:mhammond]]

We added this for easier testing, but there's a concern that in some cases where users are running different Firefox versions and we want to manage flipping this pref (either to enable this, or disable after problems) that syncing it will get in the way.

We should just not sync it to be conservative.

Comment 1

[Mark Hammond (PTO; back Oct-3) [:markh] [:mhammond]]

Attachment: Bug 1642271 - don't sync the webextensions.storage.sync.kinto preference. r?lina

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/3f9e41fb13c7
don't sync the webextensions.storage.sync.kinto preference. r=lina

Comment 3

[Dorel Luca [:dluca]]

https://hg.mozilla.org/mozilla-central/rev/3f9e41fb13c7

Comment 4

[Lina Butler [:lina]]

Comment on attachment 9153069 [details]
Bug 1642271 - don't sync the webextensions.storage.sync.kinto preference. r?lina

Beta/Release Uplift Approval Request

• User impact if declined: Confusing and possibly unexpected results for power users who enable the new Rust storage.sync backend but also manage extension storage syncing separately from add-ons
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): One-line change to not automatically sync the new Rust backend pref across all of a user's devices. This will simplify rollout of the new backend, which is currently pref'd off for everyone, but which we hope to do in Beta 78.
• String changes made/needed: None

Comment 5

[Julien Cristau [:jcristau]]

Comment on attachment 9153069 [details]
Bug 1642271 - don't sync the webextensions.storage.sync.kinto preference. r?lina

approved for 78.0b3, thanks

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/30cdd441cc37

Comment 7

[Victor Carciu]

Verified as fixed in both FF78 and FF79.