Closed Bug 1642305 Opened 1 month ago Closed 1 month ago

input type="number" have a big padding in subdialogs

Categories

(Thunderbird :: Theme, task)

Tracking

(thunderbird78 fixed)

RESOLVED FIXED
Thunderbird 79.0
Tracking Status
thunderbird78 --- fixed

People

(Reporter: Paenglab, Assigned: Paenglab)

Details

Attachments

(1 file, 1 obsolete file)

In subdialogs the input type="number" have a unneeded padding.

Bug 1632850 stopped the double loading of stylesheets. But because of this, the in the XHTML files loaded preferences.css was before the, through subdialogs.js loaded, common.css in the stylesheet list. Because of this the rules in preferences.css did no more overwrite the commom.css rules.

Removing preferences.css from the XHTML file lets the stylesheets load in the correct oder through subdialogs.js.

Assignee: nobody → richard.marti
Status: NEW → ASSIGNED
Attachment #9153123 - Flags: review?(alessandro)
Comment on attachment 9153123 [details] [diff] [review]
1642305-subdialogs-no-preferences-css.patch

Review of attachment 9153123 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks, just a little nit.

::: mail/components/preferences/fonts.xhtml
@@ -3,5 @@
>     - License, v. 2.0. If a copy of the MPL was not distributed with this
>     - file, You can obtain one at https://mozilla.org/MPL/2.0/. -->
>  
>  <?xml-stylesheet href="chrome://global/skin/global.css"?>
> -<?xml-stylesheet href="chrome://messenger/skin/messenger.css"?>

Let's keep the messenger here due to the styling of the fieldsets on Linux.
Attachment #9153123 - Flags: review?(alessandro) → feedback+

Added the messenger.css include to sendoptions.xhtml too because it showed the border too (also before the patch).

Attachment #9153123 - Attachment is obsolete: true
Attachment #9153478 - Flags: review?(alessandro)
Attachment #9153478 - Flags: approval-comm-beta?
Comment on attachment 9153478 [details] [diff] [review]
1642305-subdialogs-no-preferences-css.patch

Review of attachment 9153478 [details] [diff] [review]:
-----------------------------------------------------------------

Perfect, thanks!
Attachment #9153478 - Flags: review?(alessandro) → review+
Target Milestone: --- → Thunderbird 79.0

Pushed by geoff@darktrojan.net:
https://hg.mozilla.org/comm-central/rev/90acb84d2bf6
Remove preferences.css from the dialog XHTML files to let it load through subdialogs.js. r=aleca

Status: ASSIGNED → RESOLVED
Closed: 1 month ago
Resolution: --- → FIXED
Comment on attachment 9153478 [details] [diff] [review]
1642305-subdialogs-no-preferences-css.patch

[Triage Comment]
Approved for beta
Attachment #9153478 - Flags: approval-comm-beta? → approval-comm-beta+
You need to log in before you can comment on or make changes to this bug.