1642305 - input type="number" have a big padding in subdialogs

Status: RESOLVED FIXED

(Thunderbird :: Theme, task)

Description

[Richard Marti (:Paenglab)]

In subdialogs the input type="number" have a unneeded padding.

Comment 1

[Richard Marti (:Paenglab)]

Attachment: 1642305-subdialogs-no-preferences-css.patch

Bug 1632850 stopped the double loading of stylesheets. But because of this, the in the XHTML files loaded preferences.css was before the, through subdialogs.js loaded, common.css in the stylesheet list. Because of this the rules in preferences.css did no more overwrite the commom.css rules.

Removing preferences.css from the XHTML file lets the stylesheets load in the correct oder through subdialogs.js.

Comment 2

[Alessandro Castellani [:aleca]]

Comment on attachment 9153123 [details] [diff] [review]
1642305-subdialogs-no-preferences-css.patch

Review of attachment 9153123 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks, just a little nit.

::: mail/components/preferences/fonts.xhtml
@@ -3,5 @@
>     - License, v. 2.0. If a copy of the MPL was not distributed with this
>     - file, You can obtain one at https://mozilla.org/MPL/2.0/. -->
>  
>  <?xml-stylesheet href="chrome://global/skin/global.css"?>
> -<?xml-stylesheet href="chrome://messenger/skin/messenger.css"?>

Let's keep the messenger here due to the styling of the fieldsets on Linux.

Comment 3

[Richard Marti (:Paenglab)]

Attachment: 1642305-subdialogs-no-preferences-css.patch

Added the messenger.css include to sendoptions.xhtml too because it showed the border too (also before the patch).

Comment 4

[Alessandro Castellani [:aleca]]

Comment on attachment 9153478 [details] [diff] [review]
1642305-subdialogs-no-preferences-css.patch

Review of attachment 9153478 [details] [diff] [review]:
-----------------------------------------------------------------

Perfect, thanks!

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/90acb84d2bf6
Remove preferences.css from the dialog XHTML files to let it load through subdialogs.js. r=aleca

Comment 6

[Wayne Mery (:wsmwk)]

Comment on attachment 9153478 [details] [diff] [review]
1642305-subdialogs-no-preferences-css.patch

[Triage Comment]
Approved for beta

Comment 7

[Rob Lemley [:rjl]]

Thunderbird 78.0b1:
https://hg.mozilla.org/releases/comm-beta/rev/1a0751bf3bb3