1642388 - Can't build on macOS. error: reference to 'Point' is ambiguous

Status: RESOLVED DUPLICATE of bug 1642266

(Core :: WebRTC, defect)

Description

[David Teller [:Yoric] - still alive but not very active]

For the past few days, I have been unable to build on macOS.

1:35.29 In file included from Unified_cpp_dom_ipc0.cpp:101:
41:35.30 In file included from /Volumes/Code/dteller/mc-proc/dom/ipc/ContentParent.cpp:234:
41:35.30 In file included from /Volumes/Code/dteller/mc-proc/media/webrtc/signaling/src/peerconnection/WebrtcGlobalParent.h:8:
41:35.30 In file included from /Volumes/Code/dteller/mc-proc/obj-x86_64-apple-darwin19.5.0/ipc/ipdl/_ipdlheaders/mozilla/dom/PWebrtcGlobalParent.h:18:
41:35.30 In file included from /Volumes/Code/dteller/mc-proc/obj-x86_64-apple-darwin19.5.0/dist/include/mozilla/media/webrtc/WebrtcGlobal.h:13:
41:35.35 In file included from /Volumes/Code/dteller/mc-proc/obj-x86_64-apple-darwin19.5.0/dist/include/mozilla/media/webrtc/WebrtcIPCTraits.h:14:
41:35.35 In file included from /Volumes/Code/dteller/mc-proc/obj-x86_64-apple-darwin19.5.0/dist/include/mtransport/transportlayerdtls.h:18:
41:35.36 In file included from /Library/Developer/CommandLineTools/SDKs/MacOSX10.14.sdk/System/Library/Frameworks/Security.framework/Headers/CipherSuite.h:33:
41:35.36 In file included from /Library/Developer/CommandLineTools/SDKs/MacOSX10.14.sdk/System/Library/Frameworks/CoreFoundation.framework/Headers/CFBase.h:77:
41:35.36 /Library/Developer/CommandLineTools/SDKs/MacOSX10.14.sdk/usr/include/MacTypes.h:543:9: error: reference to 'Point' is ambiguous
41:35.36 typedef Point *                         PointPtr;
41:35.36         ^
41:35.36 /Volumes/Code/dteller/mc-proc/obj-x86_64-apple-darwin19.5.0/dist/include/mozilla/gfx/Point.h:159:34: note: candidate found by name lookup is 'mozilla::gfx::Point'
41:35.39 typedef PointTyped<UnknownUnits> Point;
41:35.39                                  ^
41:35.39 /Library/Developer/CommandLineTools/SDKs/MacOSX10.14.sdk/usr/include/MacTypes.h:538:8: note: candidate found by name lookup is 'Point'
41:35.39 struct Point {
41:35.39        ^
41:35.39 /Library/Developer/CommandLineTools/SDKs/MacOSX10.14.sdk/usr/include/MacTypes.h:550:16: error: reference to 'Rect' is ambiguous
41:35.39 typedef struct Rect                     Rect;
41:35.39                ^
41:35.39 /Library/Developer/CommandLineTools/SDKs/MacOSX10.14.sdk/usr/include/MacTypes.h:544:8: note: candidate found by name lookup is 'Rect'
41:35.39 struct Rect {
41:35.39        ^
41:35.39 /Volumes/Code/dteller/mc-proc/obj-x86_64-apple-darwin19.5.0/dist/include/mozilla/gfx/Rect.h:299:33: note: candidate found by name lookup is 'mozilla::gfx::Rect'
41:35.39 typedef RectTyped<UnknownUnits> Rect;

Tested with macOS X SDKs 10.14 and 10.15 (which I think are the only ones that can be downloaded officially these days).

Comment 1

[Byron Campen [:bwc]]

Same here.

Comment 2

[Byron Campen [:bwc]]

This seems like a unified compilation problem to me. Apparently there was a change that is causing mozilla::gfx::Point to be picked up in the same compilation unit that ContentParent.cpp is in, which is resulting in a name collision.

Comment 3

[David Teller [:Yoric] - still alive but not very active]

So we should isolate ContentParent.cpp?

Comment 4

[Byron Campen [:bwc]]

Perhaps. It might also be an include order problem, because of the sheer amount of stuff ContentParent.cpp picks up. I'm trying to figure out when the build broke.

Comment 5

[Nico Grunbaum [:ng, @chew:mozilla.org]]

Byron, I think this is the same as bug 1642266. David, if you have time, could you try the patch from bug 1642449?

Comment 6

[David Teller [:Yoric] - still alive but not very active]

Fix confirmed.

Comment 7

[Nico Grunbaum [:ng, @chew:mozilla.org]]

Thanks.