1642455 - Add 'isEnrollFirstStartup' targeting for users that see "FirstStartup"

Status: RESOLVED FIXED

(Firefox :: Messaging System, enhancement, P1)

Description

[Punam Dahiya [:pdahiya]]

Scope of this bug is to add targeting 'isEnrollFirstStartup' to enroll users who have seen FirstStartup during FirstRun.

https://searchfox.org/mozilla-central/source/toolkit/modules/FirstStartup.jsm#54
sets runAsync false for FirstRun and calls RemoteSettingsExperimentLoader.init from Normandy.jsm. we can pass runAsync value to identify first run flow while evaluating targeting inside RemoteSettingsExperimentLoader

https://searchfox.org/mozilla-central/source/toolkit/components/normandy/Normandy.jsm#118

https://searchfox.org/mozilla-central/source/toolkit/components/messaging-system/lib/RemoteSettingsExperimentLoader.jsm#116

https://searchfox.org/mozilla-central/source/toolkit/components/messaging-system/experiments/ExperimentManager.jsm#55

Comment 1

[Nan Jiang [:nanj]]

Attachment: Bug 1642455 - Add a targeting attribute for firstStartup r=k88hudson,mythmon

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/478433f027a5
Add a targeting attribute for firstStartup r=mythmon

Comment 3

[Dorel Luca [:dluca]]

https://hg.mozilla.org/mozilla-central/rev/478433f027a5

Comment 4

[Punam Dahiya [:pdahiya]]

This fix should help solidify enrollment for planned first run 78 multistage onboarding experiment and should be uplifted. Thanks

Comment 5

[Nan Jiang [:nanj]]

[Tracking Requested - why for this release]: this would improve the enrollment reliability for the first-run related experiments. We'd like to get it uplifted so that those scheduled experiments for 78 could benefit from it.

Comment 6

[Julien Cristau [:jcristau]]

Feel free to request uplift, but I don't think I need to track this.

Comment 7

[Nan Jiang [:nanj]]

Comment on attachment 9153588 [details]
Bug 1642455 - Add a targeting attribute for firstStartup r=k88hudson,mythmon

Beta/Release Uplift Approval Request

• User impact if declined: We can't reliably enroll users for the first-run (about:welcome) experiments.
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): This is not a user-facing feature, just an enhancement for the experiment enrollment for Firefox Messaging System.
• String changes made/needed: None

Comment 8

[Julien Cristau [:jcristau]]

Comment on attachment 9153588 [details]
Bug 1642455 - Add a targeting attribute for firstStartup r=k88hudson,mythmon

approved for 78.0b5

Comment 9

[Julien Cristau [:jcristau]]

https://hg.mozilla.org/releases/mozilla-beta/rev/da58a0ad2aa5