1642468 - Remove usages of outer windowID's from LoadInfo and instead use browsing context ID

Status: RESOLVED FIXED

(WebExtensions :: Request Handling, task)

Description

[Anny Gakhokidze [:annyG]]

In https://bugzilla.mozilla.org/show_bug.cgi?id=1631859#c2 I stated that we should avoid using outer windowID's in LoadInfo and instead use browsing context Id.

In this bug I will remove usages of mParentOuterWindowID, mOuterWindowID , mFrameOuterWindowID and mTopOuterWindowID in LoadInfo and replace them with corresponding browsing context ID.

Comment 1

[Chris Peterson [:cpeterson]]

This bug is a Fission Nightly blocker (milestone M6c).

Comment 2

[Chris Peterson [:cpeterson]]

Moving to M6a because Anny is actively working on this bug now.

Comment 3

[Anny Gakhokidze [:annyG]]

Making this change would help fix incorrect frameIds for OOP frames and ensure subresources have correct parentFrameIds (see https://bugzilla.mozilla.org/show_bug.cgi?id=1631859#c2)

Comment 4

[Neha Kochar [:neha]]

Pushing out to M6b as Anny is blocked on zombie's bug 1580764 and this bug affects only webextenstions.

Comment 5

[Anny Gakhokidze [:annyG]]

Attachment: Bug 1642468 - Part 1: Remove all outer windowId fields from LoadInfo, r=kmag!

Comment 6

[Anny Gakhokidze [:annyG]]

Attachment: Bug 1642468 - Part 2: Remove outer windowId from LoadInfo constructors, r=kmag!

Depends on D83562

Comment 7

[Anny Gakhokidze [:annyG]]

Attachment: Bug 1642468 - Part 3: Add a test to verify that frameId for the image and the frame that embeds it is the same in extensions, r=kmag!

Depends on D83563

Comment 8

[Anny Gakhokidze [:annyG]]

Attachment: Bug 1642468 - Part 4: Fix usage of parentWindowId and windowId in ProxyChannelFilter.jsm, r=kmag!

Depends on D83564

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/51811663a309
Part 1: Remove all outer windowId fields from LoadInfo, r=kmag
https://hg.mozilla.org/integration/autoland/rev/9af95e2e83b0
Part 2: Remove outer windowId from LoadInfo constructors, r=kmag
https://hg.mozilla.org/integration/autoland/rev/791d7f2bd61e
Part 3: Add a test to verify that frameId for the image and the frame that embeds it is the same in extensions, r=kmag
https://hg.mozilla.org/integration/autoland/rev/b1033f93bf52
Part 4: Fix usage of parentWindowId and windowId in ProxyChannelFilter.jsm, r=kmag

Comment 10

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/51811663a309
https://hg.mozilla.org/mozilla-central/rev/9af95e2e83b0
https://hg.mozilla.org/mozilla-central/rev/791d7f2bd61e
https://hg.mozilla.org/mozilla-central/rev/b1033f93bf52