Closed Bug 1642468 Opened 4 months ago Closed 3 months ago

Remove usages of outer windowID's from LoadInfo and instead use browsing context ID

Categories

(WebExtensions :: Request Handling, task)

task

Tracking

(Fission Milestone:M6b, firefox80 fixed)

RESOLVED FIXED
mozilla80
Fission Milestone M6b
Tracking Status
firefox80 --- fixed

People

(Reporter: annyG, Assigned: annyG)

References

(Blocks 1 open bug)

Details

Attachments

(4 files)

In https://bugzilla.mozilla.org/show_bug.cgi?id=1631859#c2 I stated that we should avoid using outer windowID's in LoadInfo and instead use browsing context Id.

In this bug I will remove usages of mParentOuterWindowID, mOuterWindowID , mFrameOuterWindowID and mTopOuterWindowID in LoadInfo and replace them with corresponding browsing context ID.

Summary: Remove usages of outer windowID's from LoadInfo and instead use browsing context ID → [meta] Remove usages of outer windowID's from LoadInfo and instead use browsing context ID
Keywords: meta
Depends on: 1642469
Depends on: 1642470
Depends on: 1642471

This bug is a Fission Nightly blocker (milestone M6c).

Fission Milestone: --- → M6c

Moving to M6a because Anny is actively working on this bug now.

Fission Milestone: M6c → M6a
Assignee: nobody → agakhokidze
Severity: -- → S3
Type: defect → task
No longer depends on: 1642469, 1642471
Summary: [meta] Remove usages of outer windowID's from LoadInfo and instead use browsing context ID → Remove usages of outer windowID's from LoadInfo and instead use browsing context ID
Summary: Remove usages of outer windowID's from LoadInfo and instead use browsing context ID → [meta] Remove usages of outer windowID's from LoadInfo and instead use browsing context ID
Keywords: meta
Summary: [meta] Remove usages of outer windowID's from LoadInfo and instead use browsing context ID → Remove usages of outer windowID's from LoadInfo and instead use browsing context ID
Blocks: 1580764

Making this change would help fix incorrect frameIds for OOP frames and ensure subresources have correct parentFrameIds (see https://bugzilla.mozilla.org/show_bug.cgi?id=1631859#c2)

No longer blocks: 1580764
Depends on: 1580764

Pushing out to M6b as Anny is blocked on zombie's bug 1580764 and this bug affects only webextenstions.

Fission Milestone: M6a → M6b
See Also: → 1631859
Pushed by agakhokidze@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/51811663a309
Part 1: Remove all outer windowId fields from LoadInfo, r=kmag
https://hg.mozilla.org/integration/autoland/rev/9af95e2e83b0
Part 2: Remove outer windowId from LoadInfo constructors, r=kmag
https://hg.mozilla.org/integration/autoland/rev/791d7f2bd61e
Part 3: Add a test to verify that frameId for the image and the frame that embeds it is the same in extensions, r=kmag
https://hg.mozilla.org/integration/autoland/rev/b1033f93bf52
Part 4: Fix usage of parentWindowId and windowId in ProxyChannelFilter.jsm, r=kmag
You need to log in before you can comment on or make changes to this bug.