Closed Bug 1642509 Opened 5 years ago Closed 5 years ago

Stray #ifndef in mail/components/preferences/general.inc.xhtml

Categories

(Thunderbird :: Preferences, defect, P1)

Product:
Thunderbird
Component:
Preferences
Type:
defect

Tracking

(thunderbird78 fixed)

Status:
RESOLVED FIXED
Milestone:
Thunderbird 79.0
Tracking Flags:
Tracking Status
thunderbird78 --- fixed

People

(Reporter: darktrojan, Assigned: darktrojan)

References

(Regression)

Details

(Keywords: regression)

Attachments

(1 file)

1642509-prefs-ifndef.diff
1.13 KB, patch
aleca
: review+
wsmwk
: approval-comm-beta+
Details | Diff | Splinter Review

Bug 1615501 removed some OS X specific things in preferences but left behind an #ifndef XP_MACOSX. The resulting document is truncated and the preferences are totally busted on Mac.

Attachment #9153278 - Flags: review?(alessandro)
Attachment #9153278 - Flags: approval-comm-beta?

Pushed by geoff@darktrojan.net:
https://hg.mozilla.org/comm-central/rev/86cea4684aca
Remove stray #ifndef in mail/components/preferences/general.inc.xhtml. rs=bustage-fix

Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 79.0
Comment on attachment 9153278 [details] [diff] [review] 1642509-prefs-ifndef.diff Review of attachment 9153278 [details] [diff] [review]: ----------------------------------------------------------------- This already landed so r+ for sure, also because it's a bustage fix.
Attachment #9153278 - Flags: review?(alessandro) → review+
Comment on attachment 9153278 [details] [diff] [review] 1642509-prefs-ifndef.diff [Triage Comment] Approved for beta important bustage fix
Attachment #9153278 - Flags: approval-comm-beta? → approval-comm-beta+
Keywords: regression
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: