1642630 - Built-in French Hunspell spellchecker is missing

Status: VERIFIED FIXED

(Firefox Build System :: General, defect, P1)

Description

[Théo Chevalier]

Hi,

As of last week, the French Nightly build stopped including the French Hunspell spellchecker.

Axel thinks it might be due to some l10n merge changes

Comment 1

[Axel Hecht [:Pike]]

[Tracking Requested - why for this release]: Requesting tracking as the regressing bug landed in 77.

Taking as I have a fix. Prioritizing to S1 as this affects all localizations that ship dictionaries.

Comment 2

[Axel Hecht [:Pike]]

Attachment: Bug 1642630, explicitly copy l10n dictionaries to l10n merge dir, r=#build

Hunspell dictionaries are interesting, as they're not falling back to
en-US, and only get shipped if they exist in a locale.
Copy them to the merge dir, if exist. The repackaged app can still decide
on whether to package them or not in libs-% and chrome-%.

Adding the dictionary dir to l10n.toml would also add the en-US dictionary,
which is not what the code is expected to do.

Comment 4

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1641184

Comment 5

[Pascal Chevrel:pascalc (PTO until April 26)]

Axel, the regressing bug landed in 78 and I am not seeing an uplift request in 77, are we sure that 77 is affected?

Comment 6

[Axel Hecht [:Pike]]

Oh, sorry, I meant to request tracking 78, can you fix that up?

Comment 7

[Pascal Chevrel:pascalc (PTO until April 26)]

Julien, FYI

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7039e542f69a
explicitly copy l10n dictionaries to l10n merge dir, r=nalexander

Comment 9

[Natalia Csoregi [:nataliaCs]]

Backed out for Android build bustage

backout: https://hg.mozilla.org/integration/autoland/rev/5aaac8ead1da567b26121de4715adfa26f7dffa9

push: https://treeherder.mozilla.org/#/jobs?repo=autoland&revision=7039e542f69a00725f35f2c708ea8220989f64da&searchStr=build&selectedTaskRun=bYrGQ-vnSSaJ8QyZ4YYFvw-0

failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=305094417&repo=autoland&lineNumber=71265

[task 2020-06-04T17:56:10.815Z] 17:56:10 INFO - 17:56:10 INFO - 0:01.41 /builds/worker/checkouts/gecko/toolkit/locales/l10n.mk:198: recipe for target 'merge-zh-TW' failed
[task 2020-06-04T17:56:10.815Z] 17:56:10 INFO - 17:56:10 INFO - 0:01.41 make[2]: *** [merge-zh-TW] Error 1
[task 2020-06-04T17:56:10.815Z] 17:56:10 INFO - 17:56:10 INFO - 0:01.41 Makefile:57: recipe for target 'chrome-zh-TW' failed
[task 2020-06-04T17:56:10.815Z] 17:56:10 INFO - 17:56:10 INFO - 0:01.41 make[1]: *** [chrome-zh-TW] Error 2
[task 2020-06-04T17:56:10.816Z] 17:56:10 INFO - 17:56:10 INFO - 0:01.41 /builds/worker/checkouts/gecko/mobile/android/build.mk:29: recipe for target 'chrome-zh-TW' failed
[task 2020-06-04T17:56:10.816Z] 17:56:10 INFO - 17:56:10 INFO - 0:01.41 make: *** [chrome-zh-TW] Error 2
[task 2020-06-04T17:56:10.836Z] 17:56:10 INFO - 17:56:10 INFO - 0:01.43 318 compiler warnings present.
[task 2020-06-04T17:56:10.945Z] 17:56:10 INFO - 17:56:10 INFO - Error running mach:
[task 2020-06-04T17:56:10.946Z] 17:56:10 INFO - 17:56:10 INFO - ['--log-no-times', 'package-multi-locale', '--locales', 'an', 'ar', 'ast', 'az', 'be', 'bg', 'bn', 'br', 'bs', 'ca', 'cak', 'cs', 'cy', 'da', 'de', 'dsb', 'el', 'en-CA', 'en-GB', 'eo', 'es-AR', 'es-CL', 'es-ES', 'es-MX', 'et', 'eu', 'fa', 'ff', 'fi', 'fr', 'fy-NL', 'ga-IE', 'gd', 'gl', 'gn', 'gu-IN', 'he', 'hi-IN', 'hr', 'hsb', 'hu', 'hy-AM', 'id', 'is', 'it', 'ja', 'ka', 'kab', 'kk', 'kn', 'ko', 'lij', 'lo', 'lt', 'lv', 'ml', 'mr', 'ms', 'my', 'nb-NO', 'ne-NP', 'nl', 'nn-NO', 'oc', 'pa-IN', 'pl', 'pt-BR', 'pt-PT', 'rm', 'ro', 'ru', 'sk', 'sl', 'son', 'sq', 'sr', 'sv-SE', 'ta', 'te', 'th', 'tr', 'trs', 'uk', 'ur', 'uz', 'vi', 'wo', 'xh', 'zam', 'zh-CN', 'zh-TW']
[task 2020-06-04T17:56:10.946Z] 17:56:10 INFO - 17:56:10 INFO - The error occurred in code that was called by the mach command. This is either
[task 2020-06-04T17:56:10.946Z] 17:56:10 INFO - 17:56:10 INFO - a bug in the called code itself or in the way that mach is calling it.
[task 2020-06-04T17:56:10.946Z] 17:56:10 INFO - 17:56:10 INFO - You can invoke |./mach busted| to check if this issue is already on file. If it
[task 2020-06-04T17:56:10.946Z] 17:56:10 INFO - 17:56:10 INFO - isn't, please use |./mach busted file package-multi-locale| to report it. If |./mach busted| is
[task 2020-06-04T17:56:10.946Z] 17:56:10 INFO - 17:56:10 INFO - misbehaving, you can also inspect the dependencies of bug 1543241.
[task 2020-06-04T17:56:10.946Z] 17:56:10 INFO - 17:56:10 INFO - If filing a bug, please include the full output of mach, including this error
[task 2020-06-04T17:56:10.946Z] 17:56:10 INFO - 17:56:10 INFO - message.
[task 2020-06-04T17:56:10.946Z] 17:56:10 INFO - 17:56:10 INFO - The details of the failure are as follows:
[task 2020-06-04T17:56:10.946Z] 17:56:10 INFO - 17:56:10 INFO - Exception: Process executed with non-0 exit code 2: [u'/builds/worker/checkouts/gecko/mach', u'build', u'chrome-zh-TW']
[task 2020-06-04T17:56:10.946Z] 17:56:10 INFO - 17:56:10 INFO - File "/builds/worker/checkouts/gecko/python/mozbuild/mozbuild/mach_commands.py", line 1576, in package_l10n
[task 2020-06-04T17:56:10.947Z] 17:56:10 INFO - 17:56:10 INFO - cwd=mozpath.join(self.topsrcdir))
[task 2020-06-04T17:56:10.947Z] 17:56:10 INFO - 17:56:10 INFO - File "/builds/worker/checkouts/gecko/python/mach/mach/mixin/process.py", line 159, in run_process
[task 2020-06-04T17:56:10.947Z] 17:56:10 INFO - 17:56:10 INFO - raise Exception('Process executed with non-0 exit code %d: %s' % (status, args))
[task 2020-06-04T17:56:10.962Z] 17:56:10 INFO - 17:56:10 ERROR - Return code: 1
[task 2020-06-04T17:56:10.963Z] 17:56:10 INFO - 17:56:10 FATAL - 'mach package-multi-locale --locales an ar ast az be bg bn br bs ca cak cs cy da de dsb el en-CA en-GB eo es-AR es-CL es-ES es-MX et eu fa ff fi fr fy-NL ga-IE gd gl gn gu-IN he hi-IN hr hsb hu hy-AM id is it ja ka kab kk kn ko lij lo lt lv ml mr ms my nb-NO ne-NP nl nn-NO oc pa-IN pl pt-BR pt-PT rm ro ru sk sl son sq sr sv-SE ta te th tr trs uk ur uz vi wo xh zam zh-CN zh-TW' did not run successfully. Please check log for errors.
[task 2020-06-04T17:56:10.963Z] 17:56:10 INFO - 17:56:10 FATAL - Running post_fatal callback...
[task 2020-06-04T17:56:10.963Z] 17:56:10 INFO - 17:56:10 FATAL - Exiting -1
[task 2020-06-04T17:56:10.963Z] 17:56:10 INFO - 17:56:10 INFO - [mozharness: 2020-06-04 17:56:10.962850Z] Finished package-multi step (failed)

Comment 10

[Axel Hecht [:Pike]]

This was due to a directory in zh-TW, I checked that this is the only locale affected against my local check-outs.

It'd be nice to have dxr up, as that indexed l10n-central, but so it goes.

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/fc754ed98c41
explicitly copy l10n dictionaries to l10n merge dir, r=nalexander

Comment 12

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/fc754ed98c41

Comment 13

[Théo Chevalier]

I can confirm this is fixed in the latest fr build on macOS
Thanks!

Comment 14

[Axel Hecht [:Pike]]

Comment on attachment 9153511 [details]
Bug 1642630, explicitly copy l10n dictionaries to l10n merge dir, r=#build

Beta/Release Uplift Approval Request

• User impact if declined: No spellchecker dictionaries for localized builds, for example for French.
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: No
• If yes, steps to reproduce: Download a French build and verify that spellchecking is available in French.
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): It's a pretty simple build change, and is verified on Nightly.

Not taking this patch would require backing out bugs 1641184, 1641791

• String changes made/needed: None

Comment 15

[Julien Cristau [:jcristau] (back April 22)]

Comment on attachment 9153511 [details]
Bug 1642630, explicitly copy l10n dictionaries to l10n merge dir, r=#build

regression fix for l10n repacks, approved for 78.0b4

Comment 16

[Julien Cristau [:jcristau] (back April 22)]

https://hg.mozilla.org/releases/mozilla-beta/rev/89d1f64238cf